Bugfix | Disable global model deletion (#475)

scaleoutsystems · Jun 27, 2023 · 826742a · 826742a
1 parent 07629ff
commit 826742a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/fedn/fedn/network/combiner/round.py b/fedn/fedn/network/combiner/round.py
@@ -362,10 +362,6 @@ def run(self, polling_interval=1.0):
                             round_meta['status'] = "Success"
                             round_meta['name'] = self.server.id
                             self.server.tracer.set_round_combiner_data(round_meta)
-                            if round_config['delete_models_storage'] == 'True':
-                                self.modelservice.models.delete(round_config['model_id'])
-                                self.server.report_status("ROUNDCONTROL: Deleting model {} from storage".format(
-                                    round_config['model_id']), flush=True)
                         elif round_config['task'] == 'validation' or round_config['task'] == 'inference':
                             self.execute_validation_round(round_config)
                         else:

diff --git a/fedn/fedn/network/dashboard/restservice.py b/fedn/fedn/network/dashboard/restservice.py
@@ -643,7 +643,7 @@ def assign():
             combiner_preferred = request.args.get('combiner', None)
 
             if combiner_preferred:
-                combiner = self.control.network.get(combiner_preferred)
+                combiner = self.control.network.get_combiner(combiner_preferred)
             else:
                 combiner = self.control.network.find_available_combiner()