fix race condition in bucket creation

scaleoutsystems · Sep 13, 2024 · 76a8f19 · 76a8f19
1 parent 3178f5b
commit 76a8f19
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/fedn/network/combiner/shared.py b/fedn/network/combiner/shared.py
@@ -8,6 +8,6 @@
 network_id = get_network_config()
 
 statestore = MongoStateStore(network_id, statestore_config["mongo_config"])
-repository = Repository(modelstorage_config["storage_config"])
+repository = Repository(modelstorage_config["storage_config"], init_buckets=False)
 
 modelservice = ModelService()
diff --git a/fedn/network/storage/s3/repository.py b/fedn/network/storage/s3/repository.py
@@ -8,7 +8,7 @@
 class Repository:
     """Interface for storing model objects and compute packages in S3 compatible storage."""
 
-    def __init__(self, config):
+    def __init__(self, config, init_buckets=True):
         self.model_bucket = config["storage_bucket"]
         self.context_bucket = config["context_bucket"]
         try:
@@ -19,9 +19,10 @@ def __init__(self, config):
         # TODO: Make a plug-in solution
         self.client = MINIORepository(config)
 
-        self.client.create_bucket(self.context_bucket)
-        self.client.create_bucket(self.model_bucket)
-        self.client.create_bucket(self.inference_bucket)
+        if init_buckets:
+            self.client.create_bucket(self.context_bucket)
+            self.client.create_bucket(self.model_bucket)
+            self.client.create_bucket(self.inference_bucket)
 
     def get_model(self, model_id):
         """Retrieve a model with id model_id.