Client sends model only once, combiner deletes staged model after tra…

…ining round
scaleoutsystems · Jan 28, 2024 · 166e460 · 166e460
1 parent 989d9b1
commit 166e460
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/fedn/fedn/network/clients/client.py b/fedn/fedn/network/clients/client.py
@@ -568,11 +568,6 @@ def _process_training_request(self, model_id):
             updated_model_id = None
             meta = {'status': 'failed', 'error': str(e)}
 
-        # Push model update to combiner server
-        updated_model_id = uuid.uuid4()
-        self.set_model(out_model, str(updated_model_id))
-        meta['upload_model'] = time.time() - tic
-
         self.state = ClientState.idle
 
         return updated_model_id, meta

diff --git a/fedn/fedn/network/combiner/roundhandler.py b/fedn/fedn/network/combiner/roundhandler.py
@@ -343,6 +343,7 @@ def execute_training_round(self, config):
             logger.info(
                 "ROUNDCONTROL: TRAINING ROUND COMPLETED. Aggregated model id: {}, Job id: {}".format(model_id, config['_job_id']))
 
+        self.modelservice.models.delete(config['model_id'])
         return data
 
     def run(self, polling_interval=1.0):