Simplified service discovery and refactoring of registry events #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronenhamias
reviewed
Sep 13, 2018
| @@ -23,7 +23,9 @@ | |||
|
|
|||
| ServiceEndpoint unregisterService(String endpointId); | |||
|
|
|||
| Flux<RegistryEvent> listen(); | |||
| Flux<ReferenceRegistryEvent> listenReferenceEvents(); | |||
There was a problem hiding this comment.
i dont like this contract its bloated to have this kind in the interface
maybe we can provide more clean interface?
There was a problem hiding this comment.
something like:
listen(RegistryEvent::reference)
listen(RegistryEvent::endpoint)
ronenhamias
reviewed
Sep 13, 2018
| Flux<RegistryEvent> listen(); | ||
| Flux<ReferenceRegistryEvent> listenReferenceEvents(); | ||
|
|
||
| Flux<EndpointRegistryEvent> listenEndpointEvents(); |
…rvices # Conflicts: # benchmarks/src/main/java/io/scalecube/services/benchmarks/services/ServicesBenchmarksState.java # examples/src/main/java/io/scalecube/examples/BootstrapExample.java # examples/src/main/java/io/scalecube/examples/helloworld/Example1.java # examples/src/main/java/io/scalecube/examples/helloworld/Example2.java # examples/src/main/java/io/scalecube/examples/orderbook/Example1.java # services/src/test/java/io/scalecube/services/ErrorFlowTest.java # services/src/test/java/io/scalecube/services/ServiceCallRemoteTest.java # services/src/test/java/io/scalecube/services/ServiceRegistryEventsTest.java # services/src/test/java/io/scalecube/services/ServiceRemoteTest.java # services/src/test/java/io/scalecube/services/ServiceTransportTest.java # services/src/test/java/io/scalecube/services/StreamingServiceTest.java # services/src/test/java/io/scalecube/services/routings/RoutersTest.java # services/src/test/java/io/scalecube/services/routings/ServiceTagsExample.java
artem-v
approved these changes
Sep 18, 2018
segabriel
deleted the
feature/hide-service-discovery-in-microservices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #331
Motivation:
For now, we have two approaches to subscribe to an available/unavailable endpoint events. But the way via discovery has a side effect. because we can receiver
registered eventwith some endpoint inside it and this endpoint is not registered in the service registry yet.