Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id fields to Annotations and Predictions for traceability #288

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gatli
Copy link
Contributor

@gatli gatli commented Apr 26, 2022

When loading annotations and predictions that have assigned IDs there was no way of searching for those in the frontend. This adds and ID field that is populated when loading Annotations and Predictions from server.

@gatli gatli requested a review from drakejwong April 26, 2022 12:26
@gatli gatli self-assigned this Apr 26, 2022
@drakejwong
Copy link
Contributor

Reiterating from Slack thread for visibility:
I'm not sure if we should pollute the constructor params, since it risks the user interpreting this as a value they can supply (e.g. when tab completing via the function signature).

What do you think of an id property — this also extends to DatasetItem, Dataset, Slice, Model, etc — rather than a constructor param? This way we can better handle the case where the object has not yet hit our backend to have an ID generated.

Base automatically changed from gunnar/validate/fix-invalid-poly-matching to master May 4, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants