Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallelize scripted #413

Closed
wants to merge 5 commits into from
Closed

parallelize scripted #413

wants to merge 5 commits into from

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Apr 23, 2024

Based on #412

Blocker: batch mode effectively ignores the custom build.properties

@@ -73,6 +73,8 @@ scalacOptions ++= List(
enablePlugins(ScriptedPlugin)
sbtPlugin := true
scriptedBufferLog := false
scriptedBatchExecution := true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

despite the intent of sbt/sbt#6151, scriptedBatchExecution is never true by default (because binVersion is "1" on sbt 1.x)

@bjaglin bjaglin force-pushed the parallel-scripted branch 3 times, most recently from cdd705d to 3f9b5be Compare April 23, 2024 22:33
scriptedBatchExecution effectively ignores custom build.properties, so this
takes a different approach to customizing the scripted based on sbt/JDK version
@bjaglin bjaglin force-pushed the parallel-scripted branch from 3f9b5be to 59e923c Compare April 23, 2024 22:54
@bjaglin
Copy link
Collaborator Author

bjaglin commented Apr 23, 2024

Reintegrating into #412

@bjaglin bjaglin closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant