Added apply methods to import selectors in Quotes #21225 #22457
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Jan 26, 2025
| @@ -2621,6 +2624,7 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching => | |||
|
|
|||
| /** Methods of the module object `val GivenSelector` */ | |||
| trait GivenSelectorModule { this: GivenSelector.type => | |||
| @experimental def apply(bound: Option[TypeTree]): GivenSelector | |||
There was a problem hiding this comment.
Suggested change
| @experimental def apply(bound: Option[TypeTree]): GivenSelector | |
| @experimental def apply(bound: Option[TypeRepr]): GivenSelector |
I would suggest internally wrapping the type in TypeTree with the default span
There was a problem hiding this comment.
That would be inconsistent with unapply and the .bound accessor method. Is that a problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21225