Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Extract dependencies via BSP #3236

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

WIP: Extract dependencies via BSP #3236

wants to merge 26 commits into from

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Dec 8, 2023

WIP branch for the feature discussed in #2640

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 85 lines in your changes are missing coverage. Please review.

Comparison is base (600d2a3) 91.18% compared to head (24078ba) 89.00%.
Report is 4 commits behind head on main.

Files Patch % Lines
...scalasteward/core/buildtool/bsp/BspExtractor.scala 0.00% 42 Missing ⚠️
...g/scalasteward/core/buildtool/bsp/BspProcess.scala 0.00% 17 Missing ⚠️
...rg/scalasteward/core/buildtool/bsp/BspClient.scala 0.00% 7 Missing ⚠️
...scalasteward/core/buildtool/gradle/GradleAlg.scala 16.66% 5 Missing ⚠️
...g/scalasteward/core/buildtool/bazel/BazelAlg.scala 20.00% 4 Missing ⚠️
...g/scalasteward/core/buildtool/bleep/BleepAlg.scala 20.00% 4 Missing ⚠️
.../scala/org/scalasteward/core/data/ArtifactId.scala 0.00% 4 Missing ⚠️
...ward/core/buildtool/bsp/BspConnectionDetails.scala 0.00% 1 Missing ⚠️
...asteward/core/buildtool/scalacli/ScalaCliAlg.scala 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3236      +/-   ##
==========================================
- Coverage   91.18%   89.00%   -2.19%     
==========================================
  Files         167      174       +7     
  Lines        3405     3502      +97     
  Branches      306      299       -7     
==========================================
+ Hits         3105     3117      +12     
- Misses        300      385      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fthomas fthomas mentioned this pull request Dec 8, 2023
fthomas added a commit that referenced this pull request Dec 13, 2023
This contains two small refactorings which minimizes the diff of the BSP
branch (#3236).
@fthomas
Copy link
Member Author

fthomas commented Sep 11, 2024

With cf26eca we can now extract dependencies from Scala CLI (1.2.1 or greater) via BSP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant