Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS engines that support local installed node should prefer local installed npm #92

Merged
merged 2 commits into from
May 18, 2023

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented May 18, 2023

Instead of using webjars npm.
The latest available (classic) webjars npm is totally outdated and can't be used with node 13+ (current node version is 20).

Related:

I like the idea suggested in #70 to just use the system installed npm if using a local installed js engine that supports node. Usually when installing node npm comes along, so that should work, also it's much more future proof, because usually the npm version installed locally is compatible with the local node installation (most people will use a node version manager like nvm anyway which handles that).

Fixes #70
Fixes #51
Fixes #82
Fixes typesafehub/npm#28

@mkurz mkurz force-pushed the npm-use-integrated branch 2 times, most recently from 82e5423 to fb927cf Compare May 18, 2023 12:47
@mkurz mkurz force-pushed the npm-use-integrated branch from fb927cf to dbff439 Compare May 18, 2023 14:43
@mkurz mkurz marked this pull request as ready for review May 18, 2023 15:17
@mkurz mkurz merged commit 6bcaf8b into sbt:main May 18, 2023
@mkurz mkurz deleted the npm-use-integrated branch May 18, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing important npm subcommands Use integrated npm? Running npm install instead of npm update
1 participant