Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix appium version to latest #762

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix appium version to latest #762

merged 1 commit into from
Sep 18, 2024

Conversation

eyaly
Copy link
Contributor

@eyaly eyaly commented Sep 15, 2024

One-line summary

Issue : #1234 (only if appropriate)

Description

A few sentences describing the overall goals of the pull request's
commits.

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Configuration change
  • Refactor/improvements
  • Documentation / non-code

Tasks

List of tasks you will do to complete the PR

  • Created Task 1
  • Created Task 2
  • To-do Task 3

Review

List of tasks the reviewer must do to review the PR

  • Tests
  • Documentation
  • CHANGELOG

Deployment Notes

These should highlight any db migrations, feature toggles, etc.

@eyaly eyaly requested a review from kb-kerem September 15, 2024 22:41
@kb-kerem
Copy link
Contributor

Hey @eyaly, I think fixing the appium version to latest in the example might be problematic when there are breaking changes. @FriggaHel @konraddysput what would be your take in this case?

@eyaly
Copy link
Contributor Author

eyaly commented Sep 16, 2024

Thanks @kb-kerem . But we can't leave it as 2.0.0 because it is not a supported version.

@kb-kerem
Copy link
Contributor

Thanks for the heads up @eyaly. Looking at the platform configurator examples (https://app.saucelabs.com/platform-configurator) for ios and android real devices, latest seems to be the way to go. I'll merge it as is 👍

@kb-kerem kb-kerem merged commit 1ef790f into main Sep 18, 2024
2 checks passed
@kb-kerem kb-kerem deleted the fix-appium-version branch September 18, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants