Redesign main table #139
Merged
Redesign main table #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # examples/package-lock.json # examples/package.json # package-lock.json # package.json # src/Components/Common/Tooltip/Tooltip.jsx # src/Components/NetworkTable/NetworkCellValue.jsx # src/Components/NetworkTable/NetworkTableHeader.jsx # src/Components/NetworkTable/NetworkTableHeader.styles.scss # src/Components/NetworkTable/NetworkTableRow.jsx # src/Components/NetworkTable/TimeChart.jsx # src/Components/NetworkTable/TimeChart.styles.scss # src/Components/NetworkTable/TimeChartTooltip.jsx # src/Containers/NetworkTableContainer.jsx # src/NetworkViewer.jsx # tests/__tests__/Components/Import/__snapshots__/ImportHar.spec.jsx.snap # tests/__tests__/Components/NetworkTable/__snapshots__/NetworkTableRow.spec.jsx.snap # tests/__tests__/Containers/__snapshots__/FilterContainer.spec.jsx.snap # tests/__tests__/Containers/__snapshots__/MainContainer.spec.jsx.snap # tests/__tests__/__snapshots__/NetworkViewer.spec.jsx.snap
sakhi-sl
reviewed
Aug 12, 2024
| const selectedReqIndex = state.get('selectedReqIndex'); | ||
|
|
||
| const ref = useRef(null); | ||
| const { elementDims } = useResizeObserver(ref); |
There was a problem hiding this comment.
You can use Autosizer from react-window that is made to handle dynamic width and height,
There was a problem hiding this comment.
I tried using Autosizer for the virtualized table dimensions but it didn't work so well with the current layout.
The ResizeObserver here is used to get the width of the table-body to set it for the table-header. This is necessary because of the scrollbar that can appear for the table-body causing the width of the body to the smaller than the header.
sakhi-sl
reviewed
Aug 12, 2024
|
|
||
| /* eslint no-underscore-dangle: 0 */ | ||
|
|
||
| export const useResizeObserver = (elementRef) => { |
There was a problem hiding this comment.
you might not need it with resize observer with AutoSizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Redesign of main table component to display network logs.
Types of Changes
What types of changes does your code introduce? Keep the ones that apply: