Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): enabled query params in stp/trigger endpoint #377

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat(api): enabled query params in stp/trigger endpoint #377

merged 1 commit into from
Oct 30, 2024

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Oct 30, 2024 •
edited
Loading

Issue

#373

Intent

  • Change the stp/trigger API endpoint to use query parameters.

Implementation

  • Adjusted the trigger route at api/src/routes/api/stp.ts.
  • Adjusted the triggerProgram method of the STPController class at api/src/controllers/stp.ts.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • Reviewer is assigned.

@YuryShkoda YuryShkoda merged commit 832f115 into main Oct 30, 2024
3 checks passed
@YuryShkoda YuryShkoda deleted the issue-373-stp-fix branch October 30, 2024 09:22
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nostrdev-com nostrdev-com nostrdev-com approved these changes

@sabhas sabhas sabhas approved these changes

@allanbowe allanbowe Awaiting requested review from allanbowe

@medjedovicm medjedovicm Awaiting requested review from medjedovicm

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YuryShkoda @sabhas @nostrdev-com @Yury4GL