Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): added multi-language support to logIn method #836

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Jun 20, 2024

Issue

Closes #835

Intent

  • Add multi-language support to logIn method of the AuthManager.

Implementation

  • Added getExpectedLogInSuccessHeader function to src/auth/loginHeader.ts.
  • Added isLogInSuccessHeaderPresent function to src/auth/loginHeader.ts.
  • Added getUserLanguage utility.

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

  • Unit tests coverage has been increased and a new threshold is set.
  • All sasjs-cli unit tests are passing (npm test).
  • (CI Runs this) All sasjs-tests are passing. If you want to run it manually (instructions available here).
  • Data Controller builds and is functional on both SAS 9 and Viya

@YuryShkoda YuryShkoda requested a review from medjedovicm June 20, 2024 14:18
@YuryShkoda YuryShkoda self-assigned this Jun 20, 2024
src/auth/AuthManager.ts Outdated Show resolved Hide resolved
src/auth/verifySas9Login.ts Outdated Show resolved Hide resolved
src/auth/verifySasViyaLogin.ts Outdated Show resolved Hide resolved
@YuryShkoda YuryShkoda requested a review from medjedovicm June 21, 2024 08:26
@allanbowe allanbowe merged commit ffd6bc5 into master Jun 21, 2024
1 check failed
@allanbowe allanbowe deleted the issue-835 branch June 21, 2024 12:40
@gh4nh
Copy link

gh4nh commented Jun 21, 2024

@allanbowe I've downloaded and implemented the index.min.js and successfully tested with a German and English browser. Thank you for your speedy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login window closes when phrase "You have signed in." is shown - only works for English browser setting
5 participants