fix: sas9 public access denied handling #755
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #150
Intent
Covers the SAS9
Public Access Denied
scenario. 2 places touched:login()
- User is not logged in. The login function is called withPublic Account
credentials. The adapter will return an object that contains an error message with error details andloggedIn
is false. (image 1.)request()
- User withPublic Account
is already logged in within current browser. App loads,request
function is called. The adapter will throw an error with details inside. (image 2.)image 1.
image 2.
Checks
No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.
sasjs-cli
unit tests are passing (npm test
).sasjs-tests
are passing. If you want to run it manually (instructions available here).