Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blob is not defined #685

Merged
merged 1 commit into from
Mar 28, 2022
Merged

fix: blob is not defined #685

merged 1 commit into from
Mar 28, 2022

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented Mar 23, 2022

Issue

closes #684

Intent

  • fix "blob is not defined" in node. This error was occurring in generateFileUploadForm function when running in cli.

Implementation

  • remove the creation of blob in cli
  • directly append the generated csv string in formData in cli

Checks

No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.

  • All sasjs-cli unit tests are passing (npm test).
    Mocked:
    image
    Server (without request.spec.server:
    image
  • All sasjs-tests are passing (instructions available here).
  • Data Controller builds and is functional on both SAS 9 and Viya
    VIYA:
    image
    SAS 9:
    image

@ghost ghost requested review from VladislavParhomchik and YuryShkoda March 23, 2022 18:29
@github-actions
Copy link

github-actions bot commented Mar 23, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 60.03% 1763/2937
🔴 Branches 40.74% 620/1522
🔴 Functions 46.98% 249/530
🟡 Lines 68.69% 2812/4094

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟢 src/file/generateFileUploadForm.ts 93.75% (-6.25% 🔻) 66.67% (-33.33% 🔻) 100% 90.32% (-9.68% 🔻)

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from d0eb1a7

@sabhas sabhas marked this pull request as draft March 23, 2022 20:22
@sabhas sabhas marked this pull request as ready for review March 23, 2022 21:48
@VladislavParhomchik
Copy link
Member

sasjs-tests failed:
image

@sabhas
Copy link
Member Author

sabhas commented Mar 28, 2022

@VladislavParhomchik all of these are passing for me
screencapture-sas-analytium-co-uk-sabhas-sasjs-tests-2022-03-28-15_19_43

@YuryShkoda
Copy link
Member

sasjs-tests failed: image

@VladislavParhomchik , is it Viya or SAS9 or both?

@sabhas
Copy link
Member Author

sabhas commented Mar 28, 2022

sasjs-tests failed: image

@VladislavParhomchik , is it Viya or SAS9 or both?

I believe its sas9 because for me same tests are failing on sas9.
On viya working fine.

@allanbowe allanbowe merged commit ee97e82 into master Mar 28, 2022
@allanbowe allanbowe deleted the issue-684 branch March 28, 2022 11:27
@allanbowe
Copy link
Member

#688 for failing tests (also failing on main branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sasjs request in cli fails when serverType is sasjs and a payload is provided
4 participants