Skip to content

Commit

Permalink
chore: requestClient naming
Browse files Browse the repository at this point in the history
  • Loading branch information
medjedovicm committed Dec 3, 2021
1 parent bdf9e2f commit c9ecc1d
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/job-execution/Sas9JobExecutor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,16 @@ import { RequestClient } from '../request/RequestClient'
* job execution requests.
*/
export class Sas9JobExecutor extends BaseJobExecutor {
private requestClient: Sas9RequestClient
private sas9RequestClient: Sas9RequestClient
constructor(
serverUrl: string,
serverType: ServerType,
private jobsPath: string,
private requestClientSingle: RequestClient,
private requestClient: RequestClient,
httpsAgentOptions?: https.AgentOptions
) {
super(serverUrl, serverType)
this.requestClient = new Sas9RequestClient(serverUrl, httpsAgentOptions)
this.sas9RequestClient = new Sas9RequestClient(serverUrl, httpsAgentOptions)
}

async execute(sasJob: string, data: any, config: any) {
Expand Down Expand Up @@ -63,7 +63,7 @@ export class Sas9JobExecutor extends BaseJobExecutor {
}
}

await this.requestClient.login(
await this.sas9RequestClient.login(
config.username,
config.password,
this.jobsPath
Expand All @@ -74,7 +74,7 @@ export class Sas9JobExecutor extends BaseJobExecutor {
? 'multipart/form-data; boundary=' + (formData as any)._boundary
: 'text/plain'

return await this.requestClient!.post(
return await this.sas9RequestClient!.post(
apiUrl,
formData,
undefined,
Expand All @@ -91,7 +91,7 @@ export class Sas9JobExecutor extends BaseJobExecutor {
resString = JSON.stringify(res)
}

this.requestClientSingle!.appendRequest(resString, sasJob, config.debug)
this.requestClient!.appendRequest(resString, sasJob, config.debug)

return res
})
Expand All @@ -102,7 +102,7 @@ export class Sas9JobExecutor extends BaseJobExecutor {
errString = JSON.stringify(errString)
}

this.requestClientSingle!.appendRequest(errString, sasJob, config.debug)
this.requestClient!.appendRequest(errString, sasJob, config.debug)

return err
})
Expand Down

1 comment on commit c9ecc1d

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 58.12% 1603/2758
🔴 Branches 39.55% 547/1383
🔴 Functions 45.63% 230/504
🟡 Lines 67.2% 2559/3808

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from c9ecc1d

Please sign in to comment.