Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing createRest method #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

dminones
Copy link

I've noticed that the example code does not work on current versions of keyston-classic.
I think this is related to this repo being outdated on new keystone-classic versions and therefore I've created this fork that fixes this issue by:

  • Updating createRest by using keystone.set to set up the routes
  • Updating README.md moving the invocation before the keystone.start

Hoping this approach works

@dminones dminones closed this Oct 31, 2019
@dminones
Copy link
Author

Closing since I've found out that this its wrong. Will review and create a new one with a proper fix

@dminones
Copy link
Author

Ok, added setCurrentRoutes to avoid losing the previously set routes

@dminones dminones reopened this Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants