-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install gh and latest version of go tools #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bake `gh` into the container * Install latest versions of goelv and gofumpt * Add a Makefile to make test builds and runs of container easier * Fix .zshrc causing some errors due to wrong completion syntax for some commands. * Uncomment install of gopls * Update help to add the build date of the container.
…save some contaienr size. * Switch to mounting the install scripts to reduce layers
sarg3nt
requested review from
BrickCForce,
Stanrofl and
aidanleuck
as code owners
November 7, 2024 02:54
Stanrofl
previously approved these changes
Nov 7, 2024
Stanrofl
reviewed
Nov 7, 2024
Stanrofl
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor spelling error
Stanrofl
approved these changes
Nov 7, 2024
BrickCForce
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10_install_system_packages.sh
and20_install_microsoft_dev_container_features.sh
to reduce image sizeMakefile
to speed up local development addingmake build
andmake run
andmake push
commands.kubectl
andhelm
completions in.zshrc
where trying to use bash.