Fix a few specific lints from clippy nursery

src/api_clients.rs

@@ -41,7 +41,7 @@ pub struct ClientSet {
 
 impl ClientSet {
     pub fn new() -> Self {
-        ClientSet {
+        Self {
             clients: HashMap::new(),
         }
     }

src/changes.rs

@@ -68,7 +68,7 @@ impl RepoChangeset {
                 associated_pr
                     .html_url
                     .as_ref()
-                    .ok_or(anyhow!("pr without an html link!?"))?
+                    .ok_or_else(|| anyhow!("pr without an html link!?"))?
                     .to_string(),
             );
 
@@ -154,7 +154,7 @@ impl CommitMetadata {
             .next()
             .unwrap_or("<empty commit message>")
             .to_string();
-        CommitMetadata {
+        Self {
             headline,
             link: commit.html_url.clone(),
         }

src/main.rs

@@ -151,7 +151,7 @@ fn find_values_yaml(workspace: String, base: &str, head: &str) -> Result<Vec<Rep
             continue;
         }
 
-        let path = new_file.path().ok_or(anyhow!("failed to get file path"))?;
+        let path = new_file.path().ok_or_else(|| anyhow!("failed to get file path"))?;
         if !path.ends_with("images.yaml") {
             continue;
         }

src/remote.rs

@@ -40,7 +40,7 @@ impl Remote {
     pub fn parse(url: &str) -> Result<Self, anyhow::Error> {
         let remote_url = Url::parse(url).context("can't parse remote")?;
         let path_elements: Vec<&str> = remote_url.path().trim_start_matches('/').split('/').collect();
-        Ok(Remote {
+        Ok(Self {
             host: remote_url.host().context("remote has no host")?.to_owned(),
             port: remote_url.port_or_known_default().context("remote has no port")?,
             owner: path_elements[0].to_string(),
@@ -51,7 +51,10 @@ impl Remote {
     }
 
     async fn get_client(&self) -> Result<(SemaphorePermit<'_>, &Arc<Octocrab>), anyhow::Error> {
-        let client = self.client.as_ref().ok_or(anyhow!("no client attached to remote"))?;
+        let client = self
+            .client
+            .as_ref()
+            .ok_or_else(|| anyhow!("no client attached to remote"))?;
         client.lock().await.context("cannot obtain semaphore for client")
     }
 
@@ -93,7 +96,7 @@ impl Remote {
             .await
             .context("failed to get pr commits")?
             .last()
-            .ok_or(anyhow!("PR contains no commits?"))?
+            .ok_or_else(|| anyhow!("PR contains no commits?"))?
             .sha
             .clone())
     }