-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renovate: Update External dependencies (major) #163
Conversation
e650b6f
to
26c0603
Compare
26c0603
to
6d55427
Compare
6d55427
to
90b04ba
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@@ -80,36 +81,37 @@ func (d *keystone) init() { | |||
if viper.Get("keystone.username") != nil { | |||
// force service logon to check validity early | |||
// this will set d.providerClient | |||
_, err := d.serviceKeystoneClient() | |||
ctx := context.Background() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the init function should probably passthru a ctx from higher up. If you are using cobra than that already provides one similar to req.Context(), otherwise you can generate one like https://github.com/sapcc/limes/blob/f8fc560b82c6826cad187cc7fb289dcc47faa7d5/main.go#L83
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
viper doesn't have a context that i can see, so I implemented it more like the example. might not make as much sense, but attempted it.
@SuperSandro2000 have I appropriately addressed the issues, or created new ones? :) |
This PR contains the following updates:
v1.14.0
->v2.1.0
v4
->v6
Release Notes
gophercloud/gophercloud (github.com/gophercloud/gophercloud)
v2.1.0
Compare Source
v2.0.0
Compare Source
MAIN BREAKING CHANGES:
objects
andcontainers
functions. If you were previously escaping names (with, for example:url.PathEscape
orurl.QueryEscape
), then you should REMOVE that and pass the intended names to Gophercloud directly.containers.ListOpts#Full
andobjects.ListOpts#Full
properties are REMOVED from the Gophercloud API. The reason for that is: plaintext listing is unfixably wrong and won't handle special characters reliably (i.e.\n
)./
), and empty object names are now rejected in Gophercloud before any call to Swift.objectstorage
:containers.ErrInvalidContainerName
is nowv1.ErrInvalidContainerName
.objectstorage
:v1.ErrEmptyContainerName
v1.ErrEmptyObjectName
objects.Copy
: thedestination
field (e.g.objects.CopyOpts#Destination
) must be in the form/container/object
: the function will reject a destination path if it doesn't start with a slash (/
).New features and improvements:
golangci/golangci-lint-action (golangci/golangci-lint-action)
v6
Compare Source
v5
Compare Source
Configuration
📅 Schedule: Branch creation - "before 8am on Friday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.