Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate: Update External dependencies (major) #163

Merged
merged 4 commits into from
Sep 5, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 2, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
github.com/gophercloud/gophercloud v1.14.0 -> v2.1.0 age adoption passing confidence require major
golangci/golangci-lint-action v4 -> v6 age adoption passing confidence action major

Release Notes

gophercloud/gophercloud (github.com/gophercloud/gophercloud)

v2.1.0

Compare Source

  • GH-3078 [networking]: add BGP VPNs support
  • GH-3086 build(deps): bump golang.org/x/crypto from 0.24.0 to 0.25.0
  • GH-3090 Adding support for field dns_publish_fixed_ip in a subnet
  • GH-3092 [neutron]: introduce Stateful argument for the security groups
  • GH-3094 [neutron]: introduce Description argument for the portforwarding
  • GH-3106 clouds: Parse trust_id from clouds.yaml
  • GH-3131 Align ServiceFail provisioning state value with Ironic
  • GH-3136 Added node.Retired

v2.0.0

Compare Source

MAIN BREAKING CHANGES:

  • Gophercloud now requires Go v1.22.
  • GH-2821 Gophercloud now escapes container and object names in all objects and containers functions. If you were previously escaping names (with, for example: url.PathEscape or url.QueryEscape), then you should REMOVE that and pass the intended names to Gophercloud directly.
  • GH-2821 The containers.ListOpts#Full and objects.ListOpts#Full properties are REMOVED from the Gophercloud API. The reason for that is: plaintext listing is unfixably wrong and won't handle special characters reliably (i.e. \n).
  • GH-2821 Empty container names, container names containing a slash (/), and empty object names are now rejected in Gophercloud before any call to Swift.
  • GH-2821 In objectstorage: containers.ErrInvalidContainerName is now v1.ErrInvalidContainerName.
  • GH-2821 New name validation errors in objectstorage:
    • v1.ErrEmptyContainerName
    • v1.ErrEmptyObjectName
  • GH-2821 In objects.Copy: the destination field (e.g. objects.CopyOpts#Destination) must be in the form /container/object: the function will reject a destination path if it doesn't start with a slash (/).
  • GH-2560 loadbalancer: Use CreateMemberOpts instead of BatchUpdateMemberOpts in PoolCreateOpts
  • GH-2886 ports: Fix value_specs implementation
  • GH-2665 Cinder: Remove multiatttach request parameter
  • GH-2936 Make Gophercloud context-aware: all function signatures triggering an HTTP call now accept a context.Context for tracing and cancellation
  • GH-2970 Remove context from the Provider client
  • GH-2904 Remove error code types

New features and improvements:

  • GH-2486 Fix BareMetalV1 version
  • GH-2492 Add tags for loadbalancer l7policy and l7rule
  • GH-2560 loadbalancer: Use CreateMemberOpts instead of BatchUpdateMemberOpts in PoolCreateOpts
  • GH-2561 compute: add ext_specs to flavor
  • GH-2613 Migrate baremetal inventory to a common location
  • GH-2724 baremetal: introduce Node Inventory API
  • GH-2725 baremetal: finish moving common inventory bits
  • GH-2736 Composable templates
  • GH-2781 baremetal: support ironic native PluginData
  • GH-2791 Add microversion utilities
  • GH-2806 Fix list ports with multiple fixedip parameters
  • GH-2809 Remove code for CDN (poppy)
  • GH-2812 Revert "Fix baremetal jobs on Ubuntu 20.04"
  • GH-2821 objects: Escape names in Gophercloud
  • GH-2828 Octavia: Add tags to resources missing them
  • GH-2834 baremetal: implemented ParsedLLDP in the standard PluginData
  • GH-2866 loadbalancer additional_vips by snigle
  • GH-2881 Adding missing QoS field for router
  • GH-2883 Context-aware methods to ProviderClient and ServiceClient
  • GH-2892 Authenticate with a clouds.yaml
golangci/golangci-lint-action (golangci/golangci-lint-action)

v6

Compare Source

v5

Compare Source


Configuration

📅 Schedule: Branch creation - "before 8am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot assigned notque Aug 2, 2024
@renovate renovate bot force-pushed the renovate/major-external-dependencies branch from e650b6f to 26c0603 Compare August 8, 2024 21:13
@renovate renovate bot force-pushed the renovate/major-external-dependencies branch from 26c0603 to 6d55427 Compare September 3, 2024 23:14
@renovate renovate bot force-pushed the renovate/major-external-dependencies branch from 6d55427 to 90b04ba Compare September 3, 2024 23:17
@coveralls
Copy link

coveralls commented Sep 4, 2024

Coverage Status

coverage: 58.859% (-0.1%) from 58.976%
when pulling 9d0a8bd on renovate/major-external-dependencies
into 2b4bfaf on master.

Copy link
Contributor Author

renovate bot commented Sep 4, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

pkg/api/util.go Outdated Show resolved Hide resolved
pkg/cmd/client.go Outdated Show resolved Hide resolved
@@ -80,36 +81,37 @@ func (d *keystone) init() {
if viper.Get("keystone.username") != nil {
// force service logon to check validity early
// this will set d.providerClient
_, err := d.serviceKeystoneClient()
ctx := context.Background()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the init function should probably passthru a ctx from higher up. If you are using cobra than that already provides one similar to req.Context(), otherwise you can generate one like https://github.com/sapcc/limes/blob/f8fc560b82c6826cad187cc7fb289dcc47faa7d5/main.go#L83

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

viper doesn't have a context that i can see, so I implemented it more like the example. might not make as much sense, but attempted it.

@notque
Copy link
Contributor

notque commented Sep 4, 2024

@SuperSandro2000 have I appropriately addressed the issues, or created new ones? :)

@notque notque merged commit c961f46 into master Sep 5, 2024
4 checks passed
@notque notque deleted the renovate/major-external-dependencies branch September 5, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants