Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add liquid nova report usage endpoint #611

Draft
wants to merge 6 commits into
base: liquid-nova
Choose a base branch
from
Draft

WIP: Add liquid nova report usage endpoint #611

wants to merge 6 commits into from
+605 −71

Conversation

Varsius
Copy link
Contributor

@Varsius Varsius commented Nov 25, 2024

Checklist:

  • If this PR is about a plugin, I tested the plugin against an OpenStack cluster.
  • I updated the documentation to describe the semantical or interface changes I introduced.

@coveralls
Copy link

Coverage Status

coverage: 79.005%. remained the same
when pulling ce060c8 on liquid-nova-report-usage
into 05df297 on liquid-nova.

majewsky
majewsky reviewed Nov 25, 2024
View reviewed changes
internal/liquids/nova/liquid.go Show resolved Hide resolved
internal/liquids/nova/liquid.go Outdated Show resolved Hide resolved
internal/liquids/nova/liquid.go Outdated Show resolved Hide resolved
@majewsky
plugins/nova: remove usage metrics
a1f5968 
As it turns out, nobody is using this: neither alerts, nor dashboards,
nor Maia.
@majewsky
Merge pull request #612 from sapcc/remove-nova-usage-metrics
7c8a827 
plugins/nova: remove usage metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majewsky majewsky majewsky left review comments

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000 SuperSandro2000 will be requested when the pull request is marked ready for review SuperSandro2000 is a code owner

@VoigtS VoigtS Awaiting requested review from VoigtS VoigtS will be requested when the pull request is marked ready for review VoigtS is a code owner

@Nuckal777 Nuckal777 Awaiting requested review from Nuckal777 Nuckal777 will be requested when the pull request is marked ready for review Nuckal777 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Varsius @coveralls @majewsky