Backend deletion #447
Merged
Backend deletion #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
force-pushed
the
backend-deletion
branch
3 times, most recently
from
ac0cc3e
to
30db5e9
Compare
SuperSandro2000
requested review from
majewsky,
VoigtS and
Nuckal777
as code owners
SuperSandro2000
force-pushed
the
backend-deletion
branch
from
30db5e9
to
200cf20
Compare
majewsky
reviewed
Oct 24, 2024
There was a problem hiding this comment.
I have read up until internal/processor (so have not looked at internal/tasks yet), but this ought to be enough for a first round.
Besides the notes below, in the Keppel API, all PUT/POST endpoints should return a client error (probably 409 Conflict) if account.IsDeleting == true. This can be done generically in findAccountFromRequest since r.Method is visible in that function.
SuperSandro2000
force-pushed
the
backend-deletion
branch
5 times, most recently
from
0290c5a
to
d8f5e57
Compare
majewsky
requested changes
Oct 30, 2024
SuperSandro2000
force-pushed
the
backend-deletion
branch
5 times, most recently
from
542be9f
to
3573584
Compare
…API and replace it with state
SuperSandro2000
force-pushed
the
backend-deletion
branch
from
3573584
to
c3a5e0c
Compare
majewsky
force-pushed
the
backend-deletion
branch
2 times, most recently
from
458c159
to
a7a2627
Compare
majewsky
force-pushed
the
backend-deletion
branch
from
3fbf0ba
to
8e6c77a
Compare
majewsky
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.