Add nova-bigvm prometheus exporter #4457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leust
force-pushed
the
bigvm_exporter
branch
3 times, most recently
from
02f9f6b
to
550e9d6
Compare
joker-at-work
requested changes
Feb 5, 2024
| @@ -78,6 +78,9 @@ spec: | |||
| resources: | |||
| {{ toYaml .Values.pod.resources.bigvm | indent 12 }} | |||
| {{- end }} | |||
| ports: | |||
| - name: bigvm-exporter | |||
There was a problem hiding this comment.
I think this ports needs to be named metrics to be automatically picked up instead of having the port annotation. That's usually how we do it.
There was a problem hiding this comment.
Do we need a service? I thought prometheus would just pick up on the pods/containers and scrape them automatically. E.g.
doesn't have an accompanyingService either.
leust
force-pushed
the
bigvm_exporter
branch
from
550e9d6
to
57ab6f1
Compare
joker-at-work
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on sapcc/nova#388