Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(identity):all users can create projects #1457

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

feat(identity):all users can create projects #1457

wants to merge 5 commits into from
+43 −36

Conversation

hgw77
Copy link
Collaborator

@hgw77 hgw77 commented Nov 6, 2024 •
edited
Loading

Summary

  • all users can create projects from domain level
  • all users can create sub projects from project level
  • no project requests anymore 👍
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@hgw77 hgw77 marked this pull request as ready for review November 19, 2024 15:31
@hgw77
Copy link
Collaborator Author

hgw77 commented Nov 19, 2024

Do Not Merge before Prod is ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edda edda Awaiting requested review from edda edda is a code owner

@andypf andypf Awaiting requested review from andypf andypf is a code owner

@ArtieReus ArtieReus Awaiting requested review from ArtieReus ArtieReus is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hgw77 @andypf