Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MXP-2548 Dont optimize projections in aggregations when calc view table hint is present #6

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

CoKueb
Copy link
Collaborator

@CoKueb CoKueb commented Jul 22, 2024

No description provided.

addSelect(selectList, aggCallSqlNode, e.getRowType());
}
if (isCountStar) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also do this only in case of a CALCULATION_VIEW?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check, but I'd say yes

…ections in aggregations when calc view table hint is present

Signed-off-by: Corvin Kuebler <[email protected]>
@CoKueb CoKueb merged commit 787feb3 into calcite-1.37.0+hotfix Jul 22, 2024
4 of 30 checks passed
@CoKueb CoKueb deleted the MXP-2548 branch July 22, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants