Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect parsing of FCIDUMP with complex-valued integrals #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bkesk
Copy link
Contributor

@bkesk bkesk commented May 1, 2024

The FCIDUMP format with complex-valued integrals should have format:

  V_real V_imag a b c d

and

boost::split(tok, msg, is_any_of(", \t()"), token_compress_on);

should split each line into 6 tokens, not 7, unless some unexpected whitespace character is included before V_real.

The FCIDUMP format with complex-valued integrals should have format:

```
  V_real V_imag a b c d
```

and 

```c++
boost::split(tok, msg, is_any_of(", \t()"), token_compress_on);
```
should split each line into 6 tokens, not 7 (unless some unexpected whitespace character is included before V_real.
@xubwa
Copy link
Collaborator

xubwa commented May 14, 2024

I used (V_real, V_imag) a b c d in complex FCIDUMP. I'm not aware of a standard definition of complex valued FCIDUMP, it should just be a arbitrary choice. Dice's complex valued relativistic integral is generated from PySCF and BAGEL which both used the format I described.

@bkesk
Copy link
Contributor Author

bkesk commented May 14, 2024

Thanks for the quick response. I suppose you're right. The general FCIDUMP format doesn't specify how to handle complex-valued integrals, it's just X a b c d where X can be real or complex. Let me see what happens when I use the format that you specified here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants