fix(core): duplicate should work with version documents #8323
+38
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
|
No changes to documentation |
|
Component Testing Report Updated Jan 20, 2025 10:47 AM (UTC) ❌ Failed Tests (3) -- expand for details
|
⚡️ Editor Performance ReportUpdated Mon, 20 Jan 2025 10:46:11 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
juice49
reviewed
Jan 20, 2025
packages/sanity/src/core/store/_legacy/document/document-pair/operations/duplicate.ts
Outdated
Show resolved
Hide resolved
| @@ -17,10 +20,19 @@ export const duplicate: OperationImpl<[baseDocumentId: string], 'NOTHING_TO_DUPL | |||
| throw new Error('cannot execute on empty document') | |||
| } | |||
|
|
|||
| // When duplicating a version document we need to create it with a version id | |||
| const versionId = snapshots.version?._id ? getVersionFromId(snapshots.version._id) : null | |||
There was a problem hiding this comment.
This process looks good, but it could be nice to get rid of that nested ternary 😅.
There was a problem hiding this comment.
Removed, I think we will need to update the function getVersionFromId name to something like getReleaseIdFromDocumentId it can be confusing with the getVersionId function
There was a problem hiding this comment.
Nice. That's a good point. I was also thinking that if getVersionFromId and isVersionId could accept undefined as a parameter, this automatically becomes simpler:
- const versionId = snapshots.version?._id ? getVersionFromId(snapshots.version._id) : null
+ const versionId = getVersionFromId(snapshots.version?._id) ?? null- release: idPair.versionId ? getVersionFromId(idPair.versionId) : undefined,
+ release: getVersionFromId(idPair.versionId),(Not a recommended change for this PR, just a thought).
There was a problem hiding this comment.
Could be, I like this simplicity but I also think there is something nice about making the check explicit in the consumers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Duplicate action should work with versions.
This PR updates how the id is created for the new document created by the duplicate action, if it's a version id it will preserve the version and it won't create a draft document.
What to review
Is this correct?
Testing
Open a version document.
Click on duplicate, it should create a new document in the same release.
Non version documents should continue being created as draft or live documents.
Notes for release