Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add github problem matcher for PR linting #8161

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Jan 2, 2025

Description

Makes ESLint errors on PRs a lot easier to deal with, as they show up on PR "Files changed":
image

What to review

I thought about adding --quiet to silence warnings, like the regular pnpm lint command is doing. But decided against it as the linter warnings are really noisy right now and I don't want the CI to mask over it, I want it to be honest so it motivates brave souls to clean up our linter config so it's no longer so noisy.

Testing

I tested this by introducing linter errors on AssetRow.tsx, like seen in the above screenshot. After seeing it working I fixed the linter issues and rebased.

Notes for release

N/A - only applies to monorepo.

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 4:42pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 4:42pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 4:42pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 4:42pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 4:42pm

Copy link
Contributor

github-actions bot commented Jan 2, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Component Testing Report Updated Jan 2, 2025 4:34 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 9s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 38s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 51s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 27s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 39s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 12s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 42s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@stipsan stipsan force-pushed the improve-ci-linting branch from 5436f01 to 7507d49 Compare January 2, 2025 15:17
Copy link
Contributor

github-actions bot commented Jan 2, 2025

⚡️ Editor Performance Report

Updated Thu, 02 Jan 2025 16:36:20 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 26.3 efps (38ms) 24.4 efps (41ms) +3ms (+7.9%)
article (body) 63.1 efps (16ms) 63.3 efps (16ms) -0ms (-/-%)
article (string inside object) 25.0 efps (40ms) 24.4 efps (41ms) +1ms (+2.5%)
article (string inside array) 23.0 efps (44ms) 23.8 efps (42ms) -2ms (-3.4%)
recipe (name) 50.0 efps (20ms) 54.1 efps (19ms) -2ms (-7.5%)
recipe (description) 55.6 efps (18ms) 55.6 efps (18ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (6ms) +0ms (-/-%)
synthetic (title) 19.4 efps (52ms) 20.0 efps (50ms) -2ms (-2.9%)
synthetic (string inside object) 20.4 efps (49ms) 20.0 efps (50ms) +1ms (+2.0%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 42ms 50ms 337ms 551ms 9.9s
article (body) 16ms 18ms 22ms 87ms 229ms 5.7s
article (string inside object) 40ms 43ms 46ms 148ms 137ms 6.7s
article (string inside array) 44ms 48ms 52ms 90ms 204ms 7.1s
recipe (name) 20ms 22ms 27ms 33ms 0ms 7.8s
recipe (description) 18ms 20ms 23ms 30ms 0ms 4.6s
recipe (instructions) 6ms 8ms 10ms 13ms 0ms 3.2s
synthetic (title) 52ms 55ms 63ms 259ms 545ms 14.4s
synthetic (string inside object) 49ms 51ms 59ms 258ms 369ms 8.4s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 62ms 76ms 603ms 1034ms 11.1s
article (body) 16ms 17ms 19ms 34ms 69ms 5.0s
article (string inside object) 41ms 44ms 59ms 176ms 253ms 7.3s
article (string inside array) 42ms 45ms 53ms 272ms 146ms 7.2s
recipe (name) 19ms 21ms 25ms 44ms 0ms 7.5s
recipe (description) 18ms 20ms 22ms 31ms 0ms 4.6s
recipe (instructions) 6ms 8ms 9ms 21ms 0ms 3.2s
synthetic (title) 50ms 53ms 66ms 129ms 145ms 11.8s
synthetic (string inside object) 50ms 53ms 58ms 95ms 772ms 8.0s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@stipsan stipsan added this pull request to the merge queue Jan 3, 2025
Merged via the queue into next with commit 323d1b1 Jan 3, 2025
57 checks passed
@stipsan stipsan deleted the improve-ci-linting branch January 3, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants