You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes ESLint errors on PRs a lot easier to deal with, as they show up on PR "Files changed":
What to review
I thought about adding --quiet to silence warnings, like the regular pnpm lint command is doing. But decided against it as the linter warnings are really noisy right now and I don't want the CI to mask over it, I want it to be honest so it motivates brave souls to clean up our linter config so it's no longer so noisy.
Testing
I tested this by introducing linter errors on AssetRow.tsx, like seen in the above screenshot. After seeing it working I fixed the linter issues and rebased.
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
38ms
42ms
50ms
337ms
551ms
9.9s
article (body)
16ms
18ms
22ms
87ms
229ms
5.7s
article (string inside object)
40ms
43ms
46ms
148ms
137ms
6.7s
article (string inside array)
44ms
48ms
52ms
90ms
204ms
7.1s
recipe (name)
20ms
22ms
27ms
33ms
0ms
7.8s
recipe (description)
18ms
20ms
23ms
30ms
0ms
4.6s
recipe (instructions)
6ms
8ms
10ms
13ms
0ms
3.2s
synthetic (title)
52ms
55ms
63ms
259ms
545ms
14.4s
synthetic (string inside object)
49ms
51ms
59ms
258ms
369ms
8.4s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
41ms
62ms
76ms
603ms
1034ms
11.1s
article (body)
16ms
17ms
19ms
34ms
69ms
5.0s
article (string inside object)
41ms
44ms
59ms
176ms
253ms
7.3s
article (string inside array)
42ms
45ms
53ms
272ms
146ms
7.2s
recipe (name)
19ms
21ms
25ms
44ms
0ms
7.5s
recipe (description)
18ms
20ms
22ms
31ms
0ms
4.6s
recipe (instructions)
6ms
8ms
9ms
21ms
0ms
3.2s
synthetic (title)
50ms
53ms
66ms
129ms
145ms
11.8s
synthetic (string inside object)
50ms
53ms
58ms
95ms
772ms
8.0s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes ESLint errors on PRs a lot easier to deal with, as they show up on PR "Files changed":
What to review
I thought about adding
--quiet
to silence warnings, like the regularpnpm lint
command is doing. But decided against it as the linter warnings are really noisy right now and I don't want the CI to mask over it, I want it to be honest so it motivates brave souls to clean up our linter config so it's no longer so noisy.Testing
I tested this by introducing linter errors on
AssetRow.tsx
, like seen in the above screenshot. After seeing it working I fixed the linter issues and rebased.Notes for release
N/A - only applies to monorepo.