Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fully support react 19 typings #8154

Draft
wants to merge 14 commits into
base: next
Choose a base branch
from
Draft

fix: fully support react 19 typings #8154

wants to merge 14 commits into from

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Jan 2, 2025

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:43pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:43pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:43pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 6:43pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 6:43pm

Copy link

socket-security bot commented Jan 2, 2025

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sanity/[email protected] environment Transitive: eval, filesystem, network, unsafe +154 28.8 MB sanity-io
npm/@types/[email protected] None +1 439 kB
npm/@types/[email protected] None 0 5.75 kB types
npm/@types/[email protected] None 0 790 kB types
npm/[email protected] Transitive: environment +1 84.2 kB
npm/[email protected] None 0 0 B

🚮 Removed packages: npm/@sanity/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link
Contributor

github-actions bot commented Jan 2, 2025

No changes to documentation

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Component Testing Report Updated Jan 2, 2025 4:35 PM (UTC)

❌ Failed Tests (3) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 39s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 52s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 27s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 30s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 42s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ❌ Failed (Inspect) 2m 13s 0 9 3
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 46s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Jan 2, 2025

⚡️ Editor Performance Report

Updated Thu, 02 Jan 2025 18:41:26 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 22.7 efps (44ms) 24.4 efps (41ms) -3ms (-6.8%)
article (body) 63.7 efps (16ms) 67.1 efps (15ms) -1ms (-/-%)
article (string inside object) 24.4 efps (41ms) 23.8 efps (42ms) +1ms (+2.4%)
article (string inside array) 22.2 efps (45ms) 20.8 efps (48ms) +3ms (+6.7%)
recipe (name) 43.5 efps (23ms) 50.0 efps (20ms) -3ms (-13.0%)
recipe (description) 51.3 efps (20ms) 55.6 efps (18ms) -2ms (-7.7%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 18.5 efps (54ms) 19.0 efps (53ms) -2ms (-2.8%)
synthetic (string inside object) 18.9 efps (53ms) 19.6 efps (51ms) -2ms (-3.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 44ms 47ms 62ms 337ms 354ms 10.5s
article (body) 16ms 19ms 24ms 108ms 125ms 5.4s
article (string inside object) 41ms 42ms 52ms 178ms 214ms 7.0s
article (string inside array) 45ms 46ms 48ms 203ms 389ms 7.2s
recipe (name) 23ms 24ms 29ms 51ms 0ms 7.3s
recipe (description) 20ms 21ms 24ms 45ms 0ms 4.7s
recipe (instructions) 5ms 6ms 7ms 31ms 0ms 3.0s
synthetic (title) 54ms 58ms 61ms 254ms 910ms 13.7s
synthetic (string inside object) 53ms 57ms 70ms 529ms 1351ms 9.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 41ms 49ms 68ms 478ms 966ms 10.7s
article (body) 15ms 22ms 40ms 98ms 358ms 5.8s
article (string inside object) 42ms 44ms 48ms 85ms 227ms 7.3s
article (string inside array) 48ms 51ms 60ms 366ms 632ms 8.0s
recipe (name) 20ms 22ms 25ms 37ms 0ms 7.5s
recipe (description) 18ms 20ms 23ms 37ms 0ms 4.5s
recipe (instructions) 5ms 6ms 7ms 9ms 0ms 3.1s
synthetic (title) 53ms 55ms 60ms 71ms 461ms 12.2s
synthetic (string inside object) 51ms 54ms 60ms 478ms 1107ms 8.4s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant