Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): copy additions for remote project bootstrapper #8141

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

RostiMelk
Copy link
Member

@RostiMelk RostiMelk commented Dec 27, 2024

Description

  • Added a success message for when a CORS entry is added
  • Added a success message for when an API token is added

image

Fixes: GRO-3076

Testing

Run

sanity init --template sanity-io/sanity-template-nextjs-clean

You should see a message for both CORS and API token

Notes for release

N/A or:

Adjusted copy in CLI

@RostiMelk RostiMelk requested a review from a team as a code owner December 27, 2024 09:19
@RostiMelk RostiMelk requested review from ricokahler and removed request for a team December 27, 2024 09:19
Copy link

vercel bot commented Dec 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:42am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:42am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:42am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:42am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 11:42am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Dec 27, 2024

Component Testing Report Updated Jan 3, 2025 11:37 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 3s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 37s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 50s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 25s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 27s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 39s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 12s 3 9 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 43s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

github-actions bot commented Dec 27, 2024

⚡️ Editor Performance Report

Updated Fri, 03 Jan 2025 11:40:07 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 23.8 efps (42ms) 25.0 efps (40ms) -2ms (-4.8%)
article (body) 59.9 efps (17ms) 65.8 efps (15ms) -1ms (-9.0%)
article (string inside object) 25.6 efps (39ms) 26.7 efps (38ms) -2ms (-3.8%)
article (string inside array) 22.7 efps (44ms) 22.7 efps (44ms) +0ms (-/-%)
recipe (name) 55.6 efps (18ms) 62.5 efps (16ms) -2ms (-11.1%)
recipe (description) 62.5 efps (16ms) 66.7 efps (15ms) -1ms (-6.3%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%)
synthetic (title) 20.0 efps (50ms) 19.8 efps (51ms) +1ms (+1.0%)
synthetic (string inside object) 19.6 efps (51ms) 21.7 efps (46ms) -5ms (-9.8%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 49ms 54ms 378ms 185ms 11.1s
article (body) 17ms 19ms 33ms 114ms 93ms 5.3s
article (string inside object) 39ms 44ms 65ms 211ms 364ms 7.3s
article (string inside array) 44ms 46ms 60ms 261ms 280ms 7.4s
recipe (name) 18ms 19ms 21ms 30ms 0ms 7.0s
recipe (description) 16ms 18ms 21ms 33ms 0ms 4.3s
recipe (instructions) 5ms 7ms 8ms 12ms 0ms 3.1s
synthetic (title) 50ms 52ms 55ms 274ms 436ms 13.2s
synthetic (string inside object) 51ms 55ms 67ms 93ms 279ms 7.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 58ms 73ms 578ms 936ms 10.6s
article (body) 15ms 17ms 21ms 101ms 95ms 5.3s
article (string inside object) 38ms 40ms 45ms 201ms 137ms 6.7s
article (string inside array) 44ms 47ms 60ms 170ms 150ms 7.2s
recipe (name) 16ms 18ms 20ms 36ms 0ms 6.3s
recipe (description) 15ms 16ms 17ms 19ms 0ms 4.2s
recipe (instructions) 5ms 7ms 8ms 8ms 0ms 3.0s
synthetic (title) 51ms 54ms 61ms 272ms 486ms 11.7s
synthetic (string inside object) 46ms 51ms 59ms 462ms 772ms 7.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@RostiMelk RostiMelk requested a review from bjoerge January 3, 2025 11:19
bjoerge
bjoerge previously approved these changes Jan 3, 2025
@RostiMelk
Copy link
Member Author

Added parentheses instead of square brackets around the project id for consistency. Need a re-review sry 😅

@RostiMelk RostiMelk requested a review from bjoerge January 3, 2025 11:59
@RostiMelk RostiMelk added this pull request to the merge queue Jan 6, 2025
Merged via the queue into next with commit f453cbc Jan 6, 2025
58 checks passed
@RostiMelk RostiMelk deleted the feat/cli/remote-template-copy-adjustments branch January 6, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants