fx: improve WorkspaceRouterProvider perf

[stipsan]

Description

What to review

Testing

Notes for release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:25pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:25pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:25pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:25pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Dec 13, 2024 7:25pm

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Dec 13, 2024 7:19 PM (UTC)

❌ Failed Tests (6) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 13s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	14s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	41s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	57s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	29s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	16s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	❌ Failed (Inspect)	4m 27s	0	0	6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 14s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	3m 4s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 50s	18	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	14s	3	9	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	43s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	29s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 55s	21	0	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

[github-actions]

⚡️ Editor Performance Report

Updated Fri, 13 Dec 2024 19:19:51 GMT

Benchmark	reference latency of sanity@latest	experiment latency of this branch	Δ (%) latency difference
article (title)	23.5 efps (43ms)	23.3 efps (43ms)	+1ms (+1.2%)	✅
article (body)	72.5 efps (14ms)	67.6 efps (15ms)	+1ms (-/-%)	✅
article (string inside object)	26.3 efps (38ms)	23.8 efps (42ms)	+4ms (+10.5%)	✅
article (string inside array)	23.3 efps (43ms)	20.8 efps (48ms)	+5ms (+11.6%)	✅
recipe (name)	50.0 efps (20ms)	54.1 efps (19ms)	-2ms (-7.5%)	✅
recipe (description)	58.8 efps (17ms)	55.6 efps (18ms)	+1ms (+5.9%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (6ms)	+1ms (-/-%)	✅
synthetic (title)	18.5 efps (54ms)	19.2 efps (52ms)	-2ms (-3.7%)	✅
synthetic (string inside object)	19.6 efps (51ms)	18.9 efps (53ms)	+2ms (+3.9%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	43ms	48ms	53ms	95ms	187ms	10.8s
article (body)	14ms	16ms	18ms	154ms	203ms	4.9s
article (string inside object)	38ms	43ms	76ms	252ms	134ms	7.0s
article (string inside array)	43ms	46ms	53ms	356ms	394ms	7.4s
recipe (name)	20ms	23ms	25ms	40ms	0ms	7.3s
recipe (description)	17ms	19ms	22ms	40ms	0ms	4.5s
recipe (instructions)	5ms	7ms	9ms	23ms	0ms	3.1s
synthetic (title)	54ms	58ms	84ms	331ms	789ms	13.8s
synthetic (string inside object)	51ms	55ms	61ms	296ms	517ms	8.3s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	43ms	47ms	53ms	231ms	254ms	12.0s
article (body)	15ms	17ms	30ms	148ms	79ms	5.4s
article (string inside object)	42ms	44ms	48ms	182ms	134ms	7.1s
article (string inside array)	48ms	50ms	59ms	237ms	313ms	7.8s
recipe (name)	19ms	21ms	24ms	60ms	1ms	7.7s
recipe (description)	18ms	20ms	23ms	41ms	0ms	4.7s
recipe (instructions)	6ms	8ms	8ms	9ms	0ms	3.1s
synthetic (title)	52ms	55ms	60ms	267ms	537ms	13.2s
synthetic (string inside object)	53ms	58ms	68ms	455ms	1008ms	8.9s

📚 Glossary

column definitions

• benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
• latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
• p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
• p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
• p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
• blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
• test duration — how long the test run took to complete.