fix: remove unsafe ref access during render

[stipsan]

Description

What to review

Testing

Notes for release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:03pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:03pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:03pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:03pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)			Dec 13, 2024 7:03pm

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Dec 13, 2024 7:00 PM (UTC)

❌ Failed Tests (6) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 13s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	13s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	42s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	56s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	28s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	16s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	❌ Failed (Inspect)	4m 27s	0	0	6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 14s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	2m 52s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 49s	18	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	14s	3	9	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	43s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	29s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 53s	21	0	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

[github-actions]

⚡️ Editor Performance Report

Updated Fri, 13 Dec 2024 19:00:36 GMT

Benchmark	reference latency of sanity@latest	experiment latency of this branch	Δ (%) latency difference
article (title)	25.6 efps (39ms)	24.4 efps (41ms)	+2ms (+5.1%)	✅
article (body)	72.5 efps (14ms)	72.5 efps (14ms)	-0ms (-/-%)	✅
article (string inside object)	28.6 efps (35ms)	27.0 efps (37ms)	+2ms (+5.7%)	✅
article (string inside array)	25.0 efps (40ms)	23.3 efps (43ms)	+3ms (+7.5%)	✅
recipe (name)	50.0 efps (20ms)	52.6 efps (19ms)	-1ms (-5.0%)	✅
recipe (description)	58.8 efps (17ms)	62.5 efps (16ms)	-1ms (-5.9%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	17.2 efps (58ms)	17.5 efps (57ms)	-1ms (-1.7%)	✅
synthetic (string inside object)	17.7 efps (57ms)	17.9 efps (56ms)	-1ms (-0.9%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	39ms	42ms	50ms	71ms	155ms	10.2s
article (body)	14ms	16ms	17ms	94ms	51ms	4.5s
article (string inside object)	35ms	41ms	55ms	240ms	242ms	6.7s
article (string inside array)	40ms	41ms	47ms	214ms	157ms	6.9s
recipe (name)	20ms	21ms	26ms	46ms	0ms	8.0s
recipe (description)	17ms	19ms	20ms	34ms	0ms	4.5s
recipe (instructions)	5ms	7ms	8ms	21ms	0ms	3.0s
synthetic (title)	58ms	63ms	77ms	315ms	832ms	14.6s
synthetic (string inside object)	57ms	60ms	73ms	576ms	1200ms	9.3s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	41ms	43ms	52ms	211ms	205ms	11.3s
article (body)	14ms	15ms	21ms	163ms	213ms	5.1s
article (string inside object)	37ms	39ms	51ms	122ms	155ms	6.7s
article (string inside array)	43ms	45ms	50ms	188ms	160ms	7.1s
recipe (name)	19ms	20ms	24ms	40ms	0ms	6.9s
recipe (description)	16ms	18ms	20ms	38ms	0ms	4.5s
recipe (instructions)	5ms	7ms	8ms	14ms	0ms	3.0s
synthetic (title)	57ms	60ms	67ms	285ms	718ms	13.5s
synthetic (string inside object)	56ms	66ms	78ms	467ms	1151ms	9.5s

📚 Glossary

column definitions

• benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
• latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
• p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
• p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
• p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
• blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
• test duration — how long the test run took to complete.