fix: remove unsafe ref access during render

[stipsan]

Description

What to review

Testing

Notes for release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:00pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:00pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:00pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 7:00pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Dec 13, 2024 7:00pm

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Dec 13, 2024 6:55 PM (UTC)

❌ Failed Tests (6) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 12s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	14s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	42s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	56s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	29s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	15s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	❌ Failed (Inspect)	4m 27s	0	0	6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 14s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	3m 3s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 49s	18	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	14s	3	9	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	43s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	29s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 54s	21	0	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

[github-actions]

⚡️ Editor Performance Report

Updated Fri, 13 Dec 2024 18:56:25 GMT

Benchmark	reference latency of sanity@latest	experiment latency of this branch	Δ (%) latency difference
article (title)	27.8 efps (36ms)	26.3 efps (38ms)	+2ms (+5.6%)	✅
article (body)	72.2 efps (14ms)	75.2 efps (13ms)	-1ms (-/-%)	✅
article (string inside object)	27.8 efps (36ms)	26.7 efps (38ms)	+2ms (+4.2%)	✅
article (string inside array)	24.4 efps (41ms)	23.8 efps (42ms)	+1ms (+2.4%)	✅
recipe (name)	47.6 efps (21ms)	47.6 efps (21ms)	+0ms (-/-%)	✅
recipe (description)	55.6 efps (18ms)	55.6 efps (18ms)	+0ms (-/-%)	✅
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (6ms)	+0ms (-/-%)	✅
synthetic (title)	18.9 efps (53ms)	18.9 efps (53ms)	+0ms (-/-%)	✅
synthetic (string inside object)	18.5 efps (54ms)	20.0 efps (50ms)	-4ms (-7.4%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	36ms	41ms	59ms	198ms	171ms	10.5s
article (body)	14ms	17ms	24ms	43ms	180ms	5.1s
article (string inside object)	36ms	38ms	42ms	157ms	152ms	6.5s
article (string inside array)	41ms	44ms	46ms	148ms	143ms	6.8s
recipe (name)	21ms	24ms	26ms	35ms	0ms	8.3s
recipe (description)	18ms	19ms	23ms	32ms	0ms	4.6s
recipe (instructions)	6ms	7ms	8ms	11ms	0ms	3.1s
synthetic (title)	53ms	55ms	68ms	297ms	688ms	13.8s
synthetic (string inside object)	54ms	56ms	71ms	460ms	911ms	8.9s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	38ms	41ms	44ms	74ms	26ms	11.3s
article (body)	13ms	16ms	20ms	182ms	177ms	4.9s
article (string inside object)	38ms	40ms	43ms	182ms	21ms	6.8s
article (string inside array)	42ms	45ms	48ms	155ms	138ms	6.8s
recipe (name)	21ms	23ms	27ms	44ms	0ms	7.7s
recipe (description)	18ms	20ms	22ms	35ms	0ms	4.6s
recipe (instructions)	6ms	8ms	8ms	19ms	0ms	3.2s
synthetic (title)	53ms	56ms	60ms	310ms	574ms	13.3s
synthetic (string inside object)	50ms	53ms	59ms	268ms	157ms	7.8s

📚 Glossary

column definitions

• benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
• latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
• p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
• p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
• p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
• blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
• test duration — how long the test run took to complete.