fix: remove unsafe ref reading during render

[stipsan]

Description

What to review

Testing

Notes for release

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 6:34pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 6:34pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 6:34pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2024 6:34pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)			Dec 13, 2024 6:34pm

[github-actions]

No changes to documentation

[github-actions]

Component Testing Report Updated Dec 13, 2024 6:30 PM (UTC)

❌ Failed Tests (6) -- expand for details

File	Status	Duration	Passed	Skipped	Failed
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 14s	15	0	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	14s	3	0	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	41s	6	0	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	56s	11	7	0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12	0
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	28s	6	0	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	16s	3	0	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	❌ Failed (Inspect)	4m 27s	0	0	6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 14s	15	0	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	3m 3s	21	0	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 48s	18	0	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	14s	3	9	0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	42s	9	0	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	29s	6	0	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	1m 53s	21	0	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3	0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3	0

[github-actions]

⚡️ Editor Performance Report

Updated Fri, 13 Dec 2024 18:30:37 GMT

Benchmark	reference latency of sanity@latest	experiment latency of this branch	Δ (%) latency difference
article (title)	23.3 efps (43ms)	24.4 efps (41ms)	-2ms (-4.7%)	✅
article (body)	72.7 efps (14ms)	67.6 efps (15ms)	+1ms (-/-%)	✅
article (string inside object)	27.4 efps (37ms)	25.3 efps (40ms)	+3ms (+8.2%)	✅
article (string inside array)	25.0 efps (40ms)	23.3 efps (43ms)	+3ms (+7.5%)	✅
recipe (name)	52.6 efps (19ms)	52.6 efps (19ms)	+0ms (-/-%)	✅
recipe (description)	58.8 efps (17ms)	60.6 efps (17ms)	-1ms (-2.9%)	✅
recipe (instructions)	99.9+ efps (5ms)	99.9+ efps (5ms)	+0ms (-/-%)	✅
synthetic (title)	20.0 efps (50ms)	19.2 efps (52ms)	+2ms (+4.0%)	✅
synthetic (string inside object)	19.6 efps (51ms)	21.3 efps (47ms)	-4ms (-7.8%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	43ms	48ms	65ms	109ms	233ms	11.0s
article (body)	14ms	15ms	18ms	202ms	235ms	4.9s
article (string inside object)	37ms	38ms	45ms	105ms	286ms	6.7s
article (string inside array)	40ms	45ms	49ms	301ms	275ms	7.1s
recipe (name)	19ms	21ms	25ms	39ms	0ms	7.3s
recipe (description)	17ms	18ms	21ms	35ms	0ms	4.4s
recipe (instructions)	5ms	6ms	7ms	9ms	0ms	3.0s
synthetic (title)	50ms	52ms	55ms	144ms	199ms	13.6s
synthetic (string inside object)	51ms	53ms	63ms	262ms	446ms	8.4s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	41ms	44ms	50ms	227ms	247ms	12.0s
article (body)	15ms	17ms	35ms	162ms	206ms	5.1s
article (string inside object)	40ms	41ms	43ms	147ms	136ms	6.8s
article (string inside array)	43ms	45ms	50ms	82ms	132ms	7.0s
recipe (name)	19ms	21ms	27ms	41ms	0ms	6.8s
recipe (description)	17ms	18ms	19ms	33ms	0ms	4.4s
recipe (instructions)	5ms	7ms	7ms	16ms	0ms	3.0s
synthetic (title)	52ms	56ms	65ms	379ms	633ms	13.7s
synthetic (string inside object)	47ms	50ms	58ms	468ms	760ms	7.9s

📚 Glossary

column definitions

• benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
• latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
• p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
• p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
• p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
• blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
• test duration — how long the test run took to complete.