You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert a change to the spinner method that was done in #8003 to make the spinner label visible again.
We're passing the label directly as an option to ora (the spinner lib) in multiple places. Luckily 'dots' is set as the default spinner anyway so this doesn't affect anything.
What to review
Testing
Run
sanity init
As a project starts bootstrapping, the spinner should now have a label beside it again.
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
38ms
44ms
53ms
216ms
197ms
10.2s
article (body)
11ms
13ms
17ms
42ms
163ms
4.7s
article (string inside object)
36ms
38ms
42ms
196ms
135ms
6.5s
article (string inside array)
42ms
44ms
51ms
168ms
139ms
7.0s
recipe (name)
20ms
23ms
28ms
56ms
0ms
7.3s
recipe (description)
18ms
20ms
21ms
29ms
0ms
4.6s
recipe (instructions)
5ms
7ms
8ms
22ms
0ms
3.1s
synthetic (title)
53ms
54ms
56ms
77ms
232ms
13.3s
synthetic (string inside object)
56ms
59ms
73ms
578ms
997ms
9.1s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
article (title)
42ms
46ms
61ms
171ms
179ms
11.1s
article (body)
13ms
15ms
19ms
72ms
198ms
4.8s
article (string inside object)
39ms
44ms
49ms
93ms
148ms
6.9s
article (string inside array)
41ms
42ms
52ms
175ms
168ms
6.8s
recipe (name)
20ms
22ms
25ms
51ms
0ms
7.3s
recipe (description)
18ms
20ms
22ms
31ms
0ms
4.6s
recipe (instructions)
5ms
7ms
8ms
9ms
0ms
3.1s
synthetic (title)
54ms
56ms
61ms
100ms
235ms
12.8s
synthetic (string inside object)
52ms
55ms
67ms
455ms
894ms
8.5s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Revert a change to the spinner method that was done in #8003 to make the spinner label visible again.
We're passing the label directly as an option to ora (the spinner lib) in multiple places. Luckily 'dots' is set as the default spinner anyway so this doesn't affect anything.
What to review
Testing
Run
As a project starts bootstrapping, the spinner should now have a label beside it again.
Notes for release
No notes as #8003 hasn't reached a release yet.