Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(cli): use default ora options in spinner method #8038

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

RostiMelk
Copy link
Member

Description

Revert a change to the spinner method that was done in #8003 to make the spinner label visible again.

We're passing the label directly as an option to ora (the spinner lib) in multiple places. Luckily 'dots' is set as the default spinner anyway so this doesn't affect anything.

What to review

Testing

Run

sanity init

As a project starts bootstrapping, the spinner should now have a label beside it again.

Notes for release

No notes as #8003 hasn't reached a release yet.

@RostiMelk RostiMelk requested a review from a team as a code owner December 13, 2024 13:17
@RostiMelk RostiMelk requested review from jordanl17 and removed request for a team December 13, 2024 13:17
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:29pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:29pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:29pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:29pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 13, 2024 1:29pm

@RostiMelk RostiMelk requested a review from juice49 December 13, 2024 13:17
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Dec 13, 2024 1:25 PM (UTC)

❌ Failed Tests (6) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 17s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 43s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 58s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 4m 28s 0 0 6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 14s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 3m 3s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 48s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 42s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 52s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 13 Dec 2024 13:29:46 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 26.7 efps (38ms) 24.1 efps (42ms) +4ms (+10.7%)
article (body) 91.3 efps (11ms) 77.5 efps (13ms) +2ms (-/-%)
article (string inside object) 28.2 efps (36ms) 25.6 efps (39ms) +4ms (+9.9%)
article (string inside array) 23.8 efps (42ms) 24.7 efps (41ms) -2ms (-3.6%)
recipe (name) 51.3 efps (20ms) 50.0 efps (20ms) +1ms (+2.6%)
recipe (description) 55.6 efps (18ms) 55.6 efps (18ms) +0ms (-/-%)
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) -0ms (-/-%)
synthetic (title) 18.9 efps (53ms) 18.5 efps (54ms) +1ms (+1.9%)
synthetic (string inside object) 18.0 efps (56ms) 19.2 efps (52ms) -4ms (-6.3%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 38ms 44ms 53ms 216ms 197ms 10.2s
article (body) 11ms 13ms 17ms 42ms 163ms 4.7s
article (string inside object) 36ms 38ms 42ms 196ms 135ms 6.5s
article (string inside array) 42ms 44ms 51ms 168ms 139ms 7.0s
recipe (name) 20ms 23ms 28ms 56ms 0ms 7.3s
recipe (description) 18ms 20ms 21ms 29ms 0ms 4.6s
recipe (instructions) 5ms 7ms 8ms 22ms 0ms 3.1s
synthetic (title) 53ms 54ms 56ms 77ms 232ms 13.3s
synthetic (string inside object) 56ms 59ms 73ms 578ms 997ms 9.1s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 42ms 46ms 61ms 171ms 179ms 11.1s
article (body) 13ms 15ms 19ms 72ms 198ms 4.8s
article (string inside object) 39ms 44ms 49ms 93ms 148ms 6.9s
article (string inside array) 41ms 42ms 52ms 175ms 168ms 6.8s
recipe (name) 20ms 22ms 25ms 51ms 0ms 7.3s
recipe (description) 18ms 20ms 22ms 31ms 0ms 4.6s
recipe (instructions) 5ms 7ms 8ms 9ms 0ms 3.1s
synthetic (title) 54ms 56ms 61ms 100ms 235ms 12.8s
synthetic (string inside object) 52ms 55ms 67ms 455ms 894ms 8.5s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@RostiMelk RostiMelk added this pull request to the merge queue Dec 13, 2024
Merged via the queue into next with commit a54f8ef Dec 13, 2024
58 checks passed
@RostiMelk RostiMelk deleted the fix/cli/use-default-ora-options branch December 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants