Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add new function getTransactionsLogs #8004

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Extracts the logic to consume from the transactions logs.
This is WIP, and part of another branch, but Jordan needs to use it in his branch, so pushing this as a standalone change.
Tests will come in the other PR

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested a review from a team as a code owner December 10, 2024 13:58
@pedrobonamin pedrobonamin requested review from ricokahler and removed request for a team December 10, 2024 13:58
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:58pm
performance-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:58pm
test-next-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:58pm
test-studio 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:58pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Dec 10, 2024 1:58pm

@pedrobonamin pedrobonamin requested review from jordanl17 and removed request for ricokahler December 10, 2024 13:58
@pedrobonamin pedrobonamin merged commit 14c3097 into corel Dec 10, 2024
29 of 35 checks passed
@pedrobonamin pedrobonamin deleted the add-get-transasction-logs branch December 10, 2024 14:00
Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Dec 10, 2024 2:08 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 14s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 54s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 54s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 48s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 42s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 57s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

⚡️ Editor Performance Report

Updated Tue, 10 Dec 2024 14:12:10 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 19.2 efps (52ms) 14.1 efps (71ms) +19ms (+36.5%) 🔴
article (body) 50.8 efps (20ms) 40.5 efps (25ms) +5ms (+25.4%) 🔴
article (string inside object) 22.5 efps (45ms) 15.4 efps (65ms) +21ms (+46.1%) 🔴
article (string inside array) 19.6 efps (51ms) 13.9 efps (72ms) +21ms (+41.2%) 🔴
recipe (name) 45.5 efps (22ms) 28.6 efps (35ms) +13ms (+59.1%) 🔴
recipe (description) 55.6 efps (18ms) 30.3 efps (33ms) +15ms (+83.3%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%)

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 52ms 59ms 65ms 211ms 299ms 13.6s
article (body) 20ms 23ms 38ms 181ms 263ms 6.5s
article (string inside object) 45ms 48ms 54ms 97ms 152ms 7.6s
article (string inside array) 51ms 59ms 65ms 369ms 474ms 8.4s
recipe (name) 22ms 24ms 29ms 48ms 0ms 7.8s
recipe (description) 18ms 20ms 21ms 39ms 0ms 4.7s
recipe (instructions) 6ms 8ms 10ms 19ms 0ms 3.3s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 71ms 80ms 109ms 307ms 1711ms 15.7s
article (body) 25ms 38ms 123ms 270ms 654ms 7.9s
article (string inside object) 65ms 75ms 86ms 329ms 1629ms 10.3s
article (string inside array) 72ms 75ms 97ms 222ms 1808ms 10.3s
recipe (name) 35ms 38ms 44ms 90ms 10ms 9.1s
recipe (description) 33ms 35ms 44ms 97ms 31ms 6.2s
recipe (instructions) 7ms 9ms 10ms 19ms 14ms 3.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants