Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): remove releaseStack from releasesStore #7990

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

Removes unused releaseStack from releasesStore.
We are using the perspective from usePerspective for this, nothing is populating the releaseStack value.

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin marked this pull request as ready for review December 9, 2024 16:16
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 4:34pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 4:34pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 4:34pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 4:34pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 9, 2024 4:34pm

@pedrobonamin pedrobonamin requested a review from a team as a code owner December 9, 2024 16:16
@pedrobonamin pedrobonamin requested review from RitaDias, bjoerge and juice49 and removed request for a team and RitaDias December 9, 2024 16:16
Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up, thanks 🙌.

Copy link
Contributor

github-actions bot commented Dec 9, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Component Testing Report Updated Dec 9, 2024 4:29 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 6s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 40s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 54s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 15s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 2m 7s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 7s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 42s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 44s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 40s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 55s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice nice, thank you!

Copy link
Contributor

github-actions bot commented Dec 9, 2024

⚡️ Editor Performance Report

Updated Mon, 09 Dec 2024 16:33:51 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 20.0 efps (50ms) 16.5 efps (61ms) +11ms (+21.0%) 🔴
article (body) 50.8 efps (20ms) 46.0 efps (22ms) +2ms (+10.4%)
article (string inside object) 24.4 efps (41ms) 17.2 efps (58ms) +17ms (+41.5%) 🔴
article (string inside array) 21.1 efps (48ms) 14.5 efps (69ms) +22ms (+45.3%) 🔴
recipe (name) 46.5 efps (22ms) 28.6 efps (35ms) +14ms (+62.8%) 🔴
recipe (description) 52.6 efps (19ms) 30.3 efps (33ms) +14ms (+73.7%) 🔴
recipe (instructions) 99.9+ efps (6ms) 99.9+ efps (7ms) +1ms (-/-%)
synthetic (title) 15.9 efps (63ms) 6.5 efps (154ms) +91ms (+143.7%) 🔴
synthetic (string inside object) 15.9 efps (63ms) 6.8 efps (148ms) +85ms (+134.1%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 50ms 55ms 67ms 212ms 256ms 12.6s
article (body) 20ms 22ms 38ms 107ms 268ms 6.3s
article (string inside object) 41ms 45ms 61ms 218ms 198ms 7.4s
article (string inside array) 48ms 50ms 55ms 199ms 174ms 7.6s
recipe (name) 22ms 24ms 29ms 54ms 0ms 8.0s
recipe (description) 19ms 21ms 24ms 41ms 0ms 4.7s
recipe (instructions) 6ms 8ms 9ms 11ms 0ms 3.3s
synthetic (title) 63ms 69ms 76ms 419ms 1269ms 15.4s
synthetic (string inside object) 63ms 67ms 96ms 243ms 798ms 9.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 61ms 65ms 78ms 239ms 1075ms 15.1s
article (body) 22ms 24ms 43ms 264ms 509ms 7.4s
article (string inside object) 58ms 62ms 72ms 241ms 1130ms 9.5s
article (string inside array) 69ms 75ms 82ms 377ms 1552ms 9.9s
recipe (name) 35ms 37ms 39ms 56ms 12ms 9.5s
recipe (description) 33ms 35ms 37ms 50ms 1ms 6.1s
recipe (instructions) 7ms 9ms 10ms 18ms 12ms 3.4s
synthetic (title) 154ms 166ms 178ms 901ms 8031ms 24.4s
synthetic (string inside object) 148ms 156ms 163ms 961ms 7673ms 18.3s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@pedrobonamin pedrobonamin merged commit c6e5ee5 into corel Dec 9, 2024
54 of 56 checks passed
@pedrobonamin pedrobonamin deleted the corel-releases-store-stack branch December 9, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants