fix(sanity): issue where banner was adding always published id #7726

RitaDias · 2024-11-01T07:17:00Z

Description

What to review

Testing

Notes for release

vercel · 2024-11-01T07:17:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2024 7:28am
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2024 7:28am
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2024 7:28am
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2024 7:28am
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 1, 2024 7:28am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)			Nov 1, 2024 7:28am

socket-security · 2024-11-01T07:18:23Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@sanity/[email protected]	None	`0`	2.19 MB	pedro-sanity
npm/@sanity/[email protected]	None	`0`	1.45 MB	mariuslundgard
npm/@sanity/[email protected]	None	`+1`	97.9 kB	sanity-io
npm/@sanity/[email protected]	Transitive: network	`+11`	5.34 MB	sanity-io
npm/@sanity/[email protected]	None	`0`	161 kB	sanity-io
npm/@sanity/[email protected]	Transitive: environment, network	`+4`	4.17 MB	sanity-io
npm/@sanity/[email protected]	Transitive: environment	`+25`	16.3 MB	mariuslundgard
npm/@sanity/[email protected]	environment Transitive: network	`+8`	14.3 MB	sanity-io
npm/[email protected]	None	`0`	35.2 kB	bjoerge

🚮 Removed packages: npm/@sanity/[email protected], npm/@sanity/[email protected], npm/@sanity/[email protected]

View full report↗︎

github-actions · 2024-11-01T07:19:47Z

No changes to documentation

RitaDias · 2024-11-01T07:20:54Z

...ty/src/structure/panes/document/documentPanel/header/perspective/DocumentPerspectiveList.tsx

+          !!(
+            typeof perspective === 'undefined' ||
+            (!editState?.published && !perspective) ||
+            !editState?.draft
+          )


This condition is not right, the draft chip is not being selected properly yet

github-actions · 2024-11-01T07:26:05Z

Component Testing Report Updated Nov 1, 2024 7:26 AM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	1m 12s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	14s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	42s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	52s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	29s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	16s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	1m 12s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	2m 47s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 48s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	14s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	43s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	29s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	57s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-11-01T07:39:30Z

⚡️ Editor Performance Report

Updated Fri, 01 Nov 2024 07:39:29 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	17.5 efps (57ms)	11.9 efps (84ms)	+27ms (+47.4%)	🔴
article (body)	63.3 efps (16ms)	63.3 efps (16ms)	+0ms (-/-%)	✅
article (string inside object)	18.9 efps (53ms)	13.7 efps (73ms)	+20ms (+37.7%)	🔴
article (string inside array)	16.4 efps (61ms)	11.1 efps (90ms)	+29ms (+47.5%)	🔴
recipe (name)	31.7 efps (32ms)	19.4 efps (52ms)	+20ms (+63.5%)	🔴
recipe (description)	35.7 efps (28ms)	22.0 efps (46ms)	+18ms (+62.5%)	🔴
recipe (instructions)	99.9+ efps (6ms)	99.9+ efps (6ms)	+0ms (-/-%)	✅
synthetic (title)	15.2 efps (66ms)	5.6 efps (178ms)	+112ms (+168.9%)	🔴
synthetic (string inside object)	15.4 efps (65ms)	6.2 efps (161ms)	+96ms (+147.7%)	🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	57ms	60ms	69ms	254ms	366ms	15.2s
article (body)	16ms	22ms	32ms	174ms	277ms	5.6s
article (string inside object)	53ms	55ms	62ms	203ms	251ms	8.3s
article (string inside array)	61ms	64ms	73ms	215ms	726ms	9.0s
recipe (name)	32ms	34ms	55ms	86ms	4ms	9.6s
recipe (description)	28ms	31ms	34ms	59ms	0ms	5.7s
recipe (instructions)	6ms	7ms	8ms	8ms	0ms	3.1s
synthetic (title)	66ms	68ms	76ms	361ms	1324ms	17.2s
synthetic (string inside object)	65ms	70ms	79ms	459ms	1459ms	9.8s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	84ms	98ms	294ms	482ms	4533ms	20.8s
article (body)	16ms	19ms	25ms	294ms	690ms	6.3s
article (string inside object)	73ms	83ms	94ms	291ms	3060ms	11.9s
article (string inside array)	90ms	97ms	103ms	326ms	3898ms	13.3s
recipe (name)	52ms	59ms	209ms	307ms	2560ms	14.9s
recipe (description)	46ms	54ms	72ms	199ms	1958ms	9.6s
recipe (instructions)	6ms	8ms	9ms	11ms	0ms	3.6s
synthetic (title)	178ms	187ms	216ms	601ms	11244ms	29.1s
synthetic (string inside object)	161ms	173ms	180ms	1252ms	11110ms	22.3s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

fix(core): issue with banner where it always added publish

b6deabb

RitaDias changed the title ~~fix(releases)~~ fix(sanity): issue where banner was adding always published id Nov 1, 2024

vercel bot deployed to Preview – performance-studio November 1, 2024 07:19 View deployment

vercel bot deployed to Preview – page-building-studio November 1, 2024 07:20 View deployment

RitaDias changed the base branch from next to corel November 1, 2024 07:20

vercel bot deployed to Preview – test-studio November 1, 2024 07:20 View deployment

RitaDias commented Nov 1, 2024

View reviewed changes

vercel bot deployed to Preview – test-next-studio November 1, 2024 07:25 View deployment

vercel bot deployed to Preview – test-compiled-studio November 1, 2024 07:28 View deployment

RitaDias closed this Nov 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(sanity): issue where banner was adding always published id #7726

fix(sanity): issue where banner was adding always published id #7726

RitaDias commented Nov 1, 2024

vercel bot commented Nov 1, 2024 •

edited

Loading

socket-security bot commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

RitaDias Nov 1, 2024

github-actions bot commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

fix(sanity): issue where banner was adding always published id #7726

fix(sanity): issue where banner was adding always published id #7726

Conversation

RitaDias commented Nov 1, 2024

Description

What to review

Testing

Notes for release

vercel bot commented Nov 1, 2024 • edited Loading

socket-security bot commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

RitaDias Nov 1, 2024

Choose a reason for hiding this comment

github-actions bot commented Nov 1, 2024

github-actions bot commented Nov 1, 2024

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

vercel bot commented Nov 1, 2024 •

edited

Loading