Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: creating perspective reference to avoid recreating releases store on perspective change #7673

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

jordanl17
Copy link
Member

…e on perspective change

Description

What to review

Testing

Notes for release

Copy link

vercel bot commented Oct 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 0:48am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 0:48am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 0:48am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 0:48am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 0:48am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Oct 25, 2024 0:48am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

Component Testing Report Updated Oct 25, 2024 12:46 AM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 11s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 13s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 53s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 28s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 8s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 2m 40s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 46s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 13s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 39s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 55s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@jordanl17 jordanl17 marked this pull request as ready for review October 25, 2024 00:55
@jordanl17 jordanl17 requested review from a team as code owners October 25, 2024 00:55
@jordanl17 jordanl17 requested review from juice49 and removed request for a team October 25, 2024 00:55
@jordanl17 jordanl17 merged commit d2ee705 into corel Oct 25, 2024
61 of 63 checks passed
@jordanl17 jordanl17 deleted the corel-perspective-recreate-store branch October 25, 2024 00:55
Copy link
Contributor

⚡️ Editor Performance Report

Updated Fri, 25 Oct 2024 00:58:56 GMT

Benchmark reference
latency of sanity@latest
experiment
latency of this branch
Δ (%)
latency difference
article (title) 17.9 efps (56ms) 12.2 efps (82ms) +26ms (+46.4%) 🔴
article (body) 50.5 efps (20ms) 56.7 efps (18ms) -2ms (-10.9%)
article (string inside object) 17.9 efps (56ms) 12.9 efps (78ms) +22ms (+38.4%) 🔴
article (string inside array) 14.2 efps (71ms) 11.4 efps (88ms) +17ms (+24.1%) 🔴
recipe (name) 27.0 efps (37ms) 19.4 efps (52ms) +15ms (+39.2%) 🔴
recipe (description) 31.3 efps (32ms) 20.8 efps (48ms) +16ms (+50.0%) 🔴
recipe (instructions) 99.9+ efps (7ms) 99.9+ efps (7ms) +0ms (-/-%)
synthetic (title) 14.5 efps (69ms) 5.6 efps (178ms) +109ms (+157.2%) 🔴
synthetic (string inside object) 14.7 efps (68ms) 6.0 efps (167ms) +99ms (+144.9%) 🔴

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 56ms 63ms 75ms 228ms 444ms 14.0s
article (body) 20ms 22ms 29ms 123ms 126ms 6.0s
article (string inside object) 56ms 57ms 61ms 266ms 276ms 8.7s
article (string inside array) 71ms 75ms 82ms 351ms 1176ms 10.0s
recipe (name) 37ms 40ms 64ms 88ms 4ms 9.8s
recipe (description) 32ms 34ms 38ms 68ms 0ms 6.2s
recipe (instructions) 7ms 10ms 10ms 34ms 0ms 3.5s
synthetic (title) 69ms 72ms 79ms 176ms 1137ms 16.1s
synthetic (string inside object) 68ms 72ms 86ms 136ms 1793ms 10.5s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 82ms 92ms 150ms 380ms 2924ms 16.8s
article (body) 18ms 21ms 38ms 145ms 301ms 6.2s
article (string inside object) 78ms 81ms 87ms 415ms 2688ms 11.2s
article (string inside array) 88ms 94ms 103ms 346ms 3095ms 12.0s
recipe (name) 52ms 55ms 59ms 99ms 956ms 11.4s
recipe (description) 48ms 51ms 56ms 104ms 839ms 8.0s
recipe (instructions) 7ms 9ms 11ms 25ms 0ms 3.4s
synthetic (title) 178ms 186ms 210ms 677ms 10012ms 27.0s
synthetic (string inside object) 167ms 177ms 192ms 824ms 9497ms 20.5s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant