fix: scheduled pub scroll list issue #7658

jordanl17 · 2024-10-22T16:59:27Z

Description

The scroll on the list of schedules in Scheduled Publish tool does not work.

This PR makes a small change to the overflow style to allow for scroll

NOW:

What to review

Testing

Notes for release

Fixing an issue with the Scheduled Publishing plugin where lists of schedules were not scrollable

vercel · 2024-10-22T16:59:31Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
page-building-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:53pm
performance-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:53pm
test-compiled-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:53pm
test-next-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:53pm
test-studio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 28, 2024 2:53pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
studio-workshop	⬜️ Ignored (Inspect)	Visit Preview		Oct 28, 2024 2:53pm

github-actions · 2024-10-22T17:06:23Z

No changes to documentation

github-actions · 2024-10-22T17:11:44Z

Component Testing Report Updated Oct 28, 2024 2:52 PM (UTC)

✅ All Tests Passed -- expand for details

File	Status	Duration	Passed	Skipped
comments/CommentInput.spec.tsx	✅ Passed (Inspect)	47s	15	0
formBuilder/ArrayInput.spec.tsx	✅ Passed (Inspect)	9s	3	0
formBuilder/inputs/PortableText/Annotations.spec.tsx	✅ Passed (Inspect)	32s	6	0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx	✅ Passed (Inspect)	39s	11	7
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx	✅ Passed (Inspect)	0s	0	12
formBuilder/inputs/PortableText/Decorators.spec.tsx	✅ Passed (Inspect)	18s	6	0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx	✅ Passed (Inspect)	11s	3	0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx	✅ Passed (Inspect)	3m 0s	0	0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx	✅ Passed (Inspect)	47s	15	0
formBuilder/inputs/PortableText/Input.spec.tsx	✅ Passed (Inspect)	1m 44s	21	0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx	✅ Passed (Inspect)	1m 18s	18	0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx	✅ Passed (Inspect)	9s	3	9
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx	✅ Passed (Inspect)	28s	9	0
formBuilder/inputs/PortableText/Styles.spec.tsx	✅ Passed (Inspect)	19s	6	0
formBuilder/inputs/PortableText/Toolbar.spec.tsx	✅ Passed (Inspect)	37s	12	0
formBuilder/tree-editing/TreeEditing.spec.tsx	✅ Passed (Inspect)	0s	0	3
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx	✅ Passed (Inspect)	0s	0	3

github-actions · 2024-10-22T17:15:05Z

⚡️ Editor Performance Report

Updated Mon, 28 Oct 2024 14:54:20 GMT

Benchmark	reference ^{latency of sanity@latest}	experiment ^{latency of this branch}	Δ (%) ^{latency difference}
article (title)	14.4 efps (70ms)	13.8 efps (73ms)	+3ms (+4.3%)	✅
article (body)	52.1 efps (19ms)	51.0 efps (20ms)	+0ms (+2.1%)	✅
article (string inside object)	15.4 efps (65ms)	15.2 efps (66ms)	+1ms (+1.5%)	✅
article (string inside array)	12.5 efps (80ms)	12.7 efps (79ms)	-1ms (-1.3%)	✅
recipe (name)	29.9 efps (34ms)	29.0 efps (35ms)	+1ms (+3.0%)	✅
recipe (description)	34.5 efps (29ms)	32.3 efps (31ms)	+2ms (+6.9%)	✅
recipe (instructions)	99.9+ efps (7ms)	99.9+ efps (6ms)	-1ms (-/-%)	✅
synthetic (title)	13.9 efps (72ms)	13.2 efps (76ms)	+4ms (+4.9%)	✅
synthetic (string inside object)	13.7 efps (73ms)	14.3 efps (70ms)	-3ms (-4.1%)	✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	70ms	76ms	97ms	370ms	835ms	14.9s
article (body)	19ms	24ms	55ms	269ms	456ms	7.3s
article (string inside object)	65ms	68ms	76ms	318ms	654ms	9.5s
article (string inside array)	80ms	86ms	98ms	288ms	1400ms	10.9s
recipe (name)	34ms	36ms	48ms	75ms	0ms	8.9s
recipe (description)	29ms	32ms	40ms	124ms	0ms	6.1s
recipe (instructions)	7ms	9ms	10ms	24ms	0ms	3.4s
synthetic (title)	72ms	76ms	84ms	463ms	1704ms	16.2s
synthetic (string inside object)	73ms	79ms	85ms	353ms	1584ms	10.9s

🧪 Experiment result

The performance result of this branch

Benchmark	latency	p75	p90	p99	blocking time	test duration
article (title)	73ms	80ms	95ms	299ms	1133ms	14.5s
article (body)	20ms	23ms	47ms	227ms	354ms	6.3s
article (string inside object)	66ms	69ms	96ms	331ms	788ms	9.8s
article (string inside array)	79ms	82ms	89ms	323ms	1473ms	10.8s
recipe (name)	35ms	38ms	50ms	87ms	7ms	8.9s
recipe (description)	31ms	34ms	41ms	63ms	12ms	6.2s
recipe (instructions)	6ms	8ms	9ms	10ms	0ms	3.2s
synthetic (title)	76ms	85ms	95ms	396ms	1922ms	16.0s
synthetic (string inside object)	70ms	78ms	91ms	533ms	2199ms	11.0s

📚 Glossary

column definitions

benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".

latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.

p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.

p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.

p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.

blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.

test duration — how long the test run took to complete.

pedrobonamin

Thanks @jordanl17 this looks good to me

vercel bot deployed to Preview – page-building-studio October 22, 2024 17:01 View deployment

vercel bot deployed to Preview – performance-studio October 22, 2024 17:01 View deployment

vercel bot deployed to Preview – test-studio October 22, 2024 17:02 View deployment

fix(scheduledPublishing): scrolling on list of schedules issue resolved

8fc57b9

jordanl17 force-pushed the fix-scheduled-pub-scroll branch from 22d31e5 to 8fc57b9 Compare October 22, 2024 17:03

jordanl17 changed the title ~~fix: scheduled pub scroll~~ fix: scheduled pub scroll list issue Oct 22, 2024

vercel bot deployed to Preview – performance-studio October 22, 2024 17:07 View deployment

vercel bot deployed to Preview – page-building-studio October 22, 2024 17:07 View deployment

vercel bot deployed to Preview – test-studio October 22, 2024 17:08 View deployment

vercel bot deployed to Preview – test-next-studio October 22, 2024 17:15 View deployment

vercel bot deployed to Preview – test-compiled-studio October 22, 2024 17:18 View deployment

Merge branch 'next' into fix-scheduled-pub-scroll

e361dbd

jordanl17 marked this pull request as ready for review October 28, 2024 14:42

jordanl17 requested a review from pedrobonamin October 28, 2024 14:42

vercel bot deployed to Preview – performance-studio October 28, 2024 14:46 View deployment

vercel bot deployed to Preview – page-building-studio October 28, 2024 14:46 View deployment

vercel bot deployed to Preview – test-studio October 28, 2024 14:46 View deployment

vercel bot deployed to Preview – test-next-studio October 28, 2024 14:51 View deployment

vercel bot deployed to Preview – test-compiled-studio October 28, 2024 14:53 View deployment

pedrobonamin approved these changes Oct 30, 2024

View reviewed changes

jordanl17 added this pull request to the merge queue Oct 30, 2024

Merged via the queue into next with commit 4e05b3a Oct 30, 2024
67 checks passed

jordanl17 deleted the fix-scheduled-pub-scroll branch October 30, 2024 14:57

jordanl17 added a commit that referenced this pull request Nov 5, 2024

fix: scheduled pub scroll list issue (#7658)

2bdccbd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: scheduled pub scroll list issue #7658

fix: scheduled pub scroll list issue #7658

jordanl17 commented Oct 22, 2024 •

edited

Loading

vercel bot commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

pedrobonamin left a comment

fix: scheduled pub scroll list issue #7658

fix: scheduled pub scroll list issue #7658

Conversation

jordanl17 commented Oct 22, 2024 • edited Loading

Description

What to review

Testing

Notes for release

vercel bot commented Oct 22, 2024 • edited Loading

github-actions bot commented Oct 22, 2024

github-actions bot commented Oct 22, 2024 • edited Loading

github-actions bot commented Oct 22, 2024 • edited Loading

⚡️ Editor Performance Report

🏠 Reference result

🧪 Experiment result

📚 Glossary

column definitions

pedrobonamin left a comment

Choose a reason for hiding this comment

jordanl17 commented Oct 22, 2024 •

edited

Loading

vercel bot commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading

github-actions bot commented Oct 22, 2024 •

edited

Loading