fix(core): drafts not using server actions always generate a created at #7503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Sep 15, 2024 10:00 PM (UTC) ✅ All Tests Passed -- expand for details
|
bjoerge
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Thanks @jordanl17! This looks like a very sensible fix to me. Left a couple of comments/suggestions. I think the isString check in particular isn't neccessary, so would be good to remove it :)
bjoerge
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes SDX-1519
There are currently instances where (when NOT using server actions), a document would be published with a
_createdAtof the publish time, rather than the time at which the draft was created.This occurred due to
_createdAton the draft not being set on creation, thus on publish the content lake was default setting tonow. This issue wouldn't be present if a refresh occurred between creating the draft and then publishing (since again content lake would fabricate acreatedAtvalue for the draft which would then pull through in studio and be used in publish. This issue didn't occur with server actions since the server always reconciled thecreatedAtand used the local server version rather than the client memory draft.What to review
The issue seemingly is just that
params.timestampwas never set on the mutation execution.It feels most appropriate to guarantee a valid
createdAtbe defined whencreate,createIfNotExistsorcreateOrReplacemutation are called, since these are the instances at which a draft/published doc are conceived. Even if thetimestampis not defined, really this should be defaulted anyway.Do you feel this makes sense, or does it feel more appropriate to require that the caller define this, otherwise they potentially risk encountering this issue again
Testing
SquashedBuffermock for global date to validate that thecreatedAtis being set according to the default fallback the first time the draft iscreateIfNotExistsNotes for release
Fix for an issue where published documents would be assigned a
createdAttimestamp of their publish time, rather than the timestamp of when the associated draft was first created.