Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): minor type usage improvement and using task plugin name #7453

Merged
merged 4 commits into from
Sep 5, 2024
Merged

refactor(core): minor type usage improvement and using task plugin name #7453

merged 4 commits into from
Sep 5, 2024

Conversation

jordanl17
Copy link
Member

Description

What to review

  • Passing function reference to collate was not matching expected types, so now anon function is defined
  • Using the tasks plugin name variable when declaring the plugin

Testing

N/A

Notes for release

N/A

@vercel Vercel
Copy link

vercel bot commented Aug 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 0:56am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 0:56am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 0:56am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 0:56am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 0:56am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Sep 3, 2024 0:56am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 30, 2024 •
edited
Loading

Component Testing Report Updated Sep 3, 2024 1:01 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 42s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 13s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 25s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 34s 12 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@jordanl17 jordanl17 marked this pull request as ready for review September 3, 2024 12:46
@jordanl17 jordanl17 requested a review from a team as a code owner September 3, 2024 12:46
RitaDias
RitaDias approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go :shipit:

@juice49
Copy link
Contributor

juice49 commented Sep 4, 2024

This looks good! One small note: as of PR #7415, collate has the old signature again, so this change might not be strictly necessary.

@jordanl17 jordanl17 changed the title refactor(tasks, core): minor type usage improvement and using task plugin name refactor(core): minor type usage improvement and using task plugin name Sep 5, 2024
@jordanl17 jordanl17 added this pull request to the merge queue Sep 5, 2024
Merged via the queue into next with commit 9547093 Sep 5, 2024
41 of 42 checks passed
@jordanl17 jordanl17 deleted the chore-corel-misc-refactor branch September 5, 2024 13:01
ricokahler pushed a commit that referenced this pull request Sep 6, 2024
@jordanl17 @ricokahler
refactor(core): minor type usage improvement and using task plugin na…
23086e2 
…me (#7453)

* refactor(core): improved typescript usage of collate for use with collecting drafts

* refactor(tasks): tasks plugin name uses var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobonamin pedrobonamin pedrobonamin approved these changes

@RitaDias RitaDias RitaDias approved these changes

@bjoerge bjoerge Awaiting requested review from bjoerge

@juice49 juice49 Awaiting requested review from juice49

@cngonzalez cngonzalez Awaiting requested review from cngonzalez

@binoy14 binoy14 Awaiting requested review from binoy14

@ricokahler ricokahler Awaiting requested review from ricokahler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jordanl17 @juice49 @RitaDias @pedrobonamin