feat(structure): update TimelineItem to match new UI, prepare for chunks #7449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
No changes to documentation |
|
Component Testing Report Updated Sep 2, 2024 8:20 AM (UTC) ✅ All Tests Passed -- expand for details
|
pedrobonamin
requested review from
ricokahler,
a team and
RitaDias
and removed request for
a team and
ricokahler
pedrobonamin
commented
Sep 2, 2024
Comment on lines
+451
to
+457
|
|
||
| /** The aria label for the menu button in the timeline item */ | ||
| 'timeline-item.menu-button.aria-label': 'Open action menu', | ||
| /** The text for the tooltip in menu button the timeline item */ | ||
| 'timeline-item.menu-button.tooltip': 'Actions', | ||
| /** The text for the expand action in the timeline item menu */ | ||
| 'timeline-item.menu.action-expand': 'Expand', |
There was a problem hiding this comment.
This are placeholder, text value is not definitive.
There was a problem hiding this comment.
Might worth adding a todo in the code so it's easier to find :)
RitaDias
reviewed
Sep 2, 2024
RitaDias
reviewed
Sep 2, 2024
RitaDias
approved these changes
Sep 2, 2024
pedrobonamin
added a commit
that referenced
this pull request
Sep 4, 2024
…nks (#7449) * feat(structure): update TimelineItem to match new UI, prepare for chunks * chore(core): export getCalendarLabels to support DateTimeInput reusability
pedrobonamin
added a commit
that referenced
this pull request
Oct 1, 2024
…nks (#7449) * feat(structure): update TimelineItem to match new UI, prepare for chunks * chore(core): export getCalendarLabels to support DateTimeInput reusability
pedrobonamin
added a commit
that referenced
this pull request
Nov 6, 2024
…nks (#7449) * feat(structure): update TimelineItem to match new UI, prepare for chunks * chore(core): export getCalendarLabels to support DateTimeInput reusability
pedrobonamin
added a commit
that referenced
this pull request
Nov 11, 2024
…nks (#7449) * feat(structure): update TimelineItem to match new UI, prepare for chunks * chore(core): export getCalendarLabels to support DateTimeInput reusability
pedrobonamin
added a commit
that referenced
this pull request
Nov 14, 2024
…nks (#7449) * feat(structure): update TimelineItem to match new UI, prepare for chunks * chore(core): export getCalendarLabels to support DateTimeInput reusability
pedrobonamin
added a commit
that referenced
this pull request
Nov 18, 2024
…nks (#7449) * feat(structure): update TimelineItem to match new UI, prepare for chunks * chore(core): export getCalendarLabels to support DateTimeInput reusability
pedrobonamin
added a commit
that referenced
this pull request
Nov 18, 2024
…nks (#7449) * feat(structure): update TimelineItem to match new UI, prepare for chunks * chore(core): export getCalendarLabels to support DateTimeInput reusability
pedrobonamin
added a commit
that referenced
this pull request
Nov 19, 2024
…nks (#7449) * feat(structure): update TimelineItem to match new UI, prepare for chunks * chore(core): export getCalendarLabels to support DateTimeInput reusability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the TimelineItem component to match the new UI.
It also adds placeholders for chunks , collaborators and menu.
A story has been added showing the changes for easier review and testing, you can find it here https://test-studio-git-corel-144.sanity.dev/test/workshop/structure;panes;documentTimelineMenu;timelineItem?scheme=light
What to review
Open a document history, does it looks as expected?
Testing
No new testing has been added, existing tests cover this functionality, when moving further, e2e tests will be included to validate the history squash
Notes for release
n/a