Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(structure): add history and review tabs to changes inspector panel #7435

Merged
merged 5 commits into from
Aug 30, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

This pull request joins the history revision and the review changes into 1 inspector, divided by tabs.

History tab

Reuses the existing Timeline component to render the view of the Timeline and allows the user to select which revision to see in the form.
By moving this into the history tab, the TimelineMenu was removed from the DocumentPanelHeader

Screenshot 2024-08-29 at 13 06 44

Review changes tab

Reuses the existing Review changes, it now includes the From and To selector, making it easier for the user to understand where the changes he is seeing are coming from.

Screenshot 2024-08-29 at 13 08 07

Other
When clicking the fields ChangeBarButton the inspector will open in the Review changes tab.
When opening the inspector through the Actions menu, it will open in the History tab

What to review

Are the changes correct?
Is there something else to consider in this changes related to the review changes that may have been lost?

Testing

e2e testing to be included once designs are on a final stage and all the changes have been approved by design.

Notes for release

n/a this will go to a feature branch

@pedrobonamin pedrobonamin requested a review from a team as a code owner August 29, 2024 11:11
@pedrobonamin pedrobonamin requested review from ricokahler and removed request for a team August 29, 2024 11:11
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:24pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:24pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:24pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:24pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 1:24pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2024 1:24pm

Copy link
Contributor

No changes to documentation

@pedrobonamin pedrobonamin requested review from bjoerge, juice49, RitaDias and jordanl17 and removed request for ricokahler August 29, 2024 11:12
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Component Testing Report Updated Aug 30, 2024 1:29 PM (UTC)

✅ All Tests Passed -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 8s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 32s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 38s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 44s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 47s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 16s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 25s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 14s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

Copy link
Contributor

@RitaDias RitaDias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!
I left one comment but as I mentioned, feels like it's out of scope for this PR :)

@bjoerge
Copy link
Member

bjoerge commented Aug 30, 2024

This is a really really nice improvement ✨

My only feedback is that it feels slightly awkward that clicking "Review Changes" from the menu takes you to the "History" tab, and there's another tab here named "Review Changes":

Screen.Recording.2024-08-30.at.14.08.18.mov

Maybe the "Review Changes" tab should be named "Changes" or "Diff" instead?

@pedrobonamin
Copy link
Contributor Author

This is a really really nice improvement ✨

My only feedback is that it feels slightly awkward that clicking "Review Changes" from the menu takes you to the "History" tab, and there's another tab here named "Review Changes":

Screen.Recording.2024-08-30.at.14.08.18.mov
Maybe the "Review Changes" tab should be named "Changes" or "Diff" instead?

Hey @bjoerge , thanks for raising this, I had a similar feeling, I went to check back the prototype and the action in the prototype has been renamed from "review changes" to "history", will update the action name here.

@pedrobonamin pedrobonamin merged commit 3cafa13 into history-updates Aug 30, 2024
42 checks passed
@pedrobonamin pedrobonamin deleted the corel-143 branch August 30, 2024 13:31
pedrobonamin added a commit that referenced this pull request Sep 4, 2024
…el (#7435)

* feat(structure): add history and review tabs to changes inspector panel

* fix(structure): move changes inspector navigation to paneRouter

* fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot

* fix(structure): rename uses of version to revision

* chore(core): rename review changes action to history
pedrobonamin added a commit that referenced this pull request Oct 1, 2024
…el (#7435)

* feat(structure): add history and review tabs to changes inspector panel

* fix(structure): move changes inspector navigation to paneRouter

* fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot

* fix(structure): rename uses of version to revision

* chore(core): rename review changes action to history
pedrobonamin added a commit that referenced this pull request Nov 6, 2024
…el (#7435)

* feat(structure): add history and review tabs to changes inspector panel

* fix(structure): move changes inspector navigation to paneRouter

* fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot

* fix(structure): rename uses of version to revision

* chore(core): rename review changes action to history
pedrobonamin added a commit that referenced this pull request Nov 11, 2024
…el (#7435)

* feat(structure): add history and review tabs to changes inspector panel

* fix(structure): move changes inspector navigation to paneRouter

* fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot

* fix(structure): rename uses of version to revision

* chore(core): rename review changes action to history
pedrobonamin added a commit that referenced this pull request Nov 14, 2024
…el (#7435)

* feat(structure): add history and review tabs to changes inspector panel

* fix(structure): move changes inspector navigation to paneRouter

* fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot

* fix(structure): rename uses of version to revision

* chore(core): rename review changes action to history
pedrobonamin added a commit that referenced this pull request Nov 18, 2024
…el (#7435)

* feat(structure): add history and review tabs to changes inspector panel

* fix(structure): move changes inspector navigation to paneRouter

* fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot

* fix(structure): rename uses of version to revision

* chore(core): rename review changes action to history
pedrobonamin added a commit that referenced this pull request Nov 18, 2024
…el (#7435)

* feat(structure): add history and review tabs to changes inspector panel

* fix(structure): move changes inspector navigation to paneRouter

* fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot

* fix(structure): rename uses of version to revision

* chore(core): rename review changes action to history
pedrobonamin added a commit that referenced this pull request Nov 19, 2024
…el (#7435)

* feat(structure): add history and review tabs to changes inspector panel

* fix(structure): move changes inspector navigation to paneRouter

* fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot

* fix(structure): rename uses of version to revision

* chore(core): rename review changes action to history
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants