-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(structure): add history and review tabs to changes inspector panel #7435
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Aug 30, 2024 1:29 PM (UTC) ✅ All Tests Passed -- expand for details
|
packages/sanity/src/structure/panes/document/inspectors/changes/ChangesTabs.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
I left one comment but as I mentioned, feels like it's out of scope for this PR :)
This is a really really nice improvement ✨ My only feedback is that it feels slightly awkward that clicking "Review Changes" from the menu takes you to the "History" tab, and there's another tab here named "Review Changes": Screen.Recording.2024-08-30.at.14.08.18.movMaybe the "Review Changes" tab should be named "Changes" or "Diff" instead? |
Hey @bjoerge , thanks for raising this, I had a similar feeling, I went to check back the prototype and the action in the prototype has been renamed from "review changes" to "history", will update the action name here. |
…el (#7435) * feat(structure): add history and review tabs to changes inspector panel * fix(structure): move changes inspector navigation to paneRouter * fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot * fix(structure): rename uses of version to revision * chore(core): rename review changes action to history
…el (#7435) * feat(structure): add history and review tabs to changes inspector panel * fix(structure): move changes inspector navigation to paneRouter * fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot * fix(structure): rename uses of version to revision * chore(core): rename review changes action to history
…el (#7435) * feat(structure): add history and review tabs to changes inspector panel * fix(structure): move changes inspector navigation to paneRouter * fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot * fix(structure): rename uses of version to revision * chore(core): rename review changes action to history
…el (#7435) * feat(structure): add history and review tabs to changes inspector panel * fix(structure): move changes inspector navigation to paneRouter * fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot * fix(structure): rename uses of version to revision * chore(core): rename review changes action to history
…el (#7435) * feat(structure): add history and review tabs to changes inspector panel * fix(structure): move changes inspector navigation to paneRouter * fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot * fix(structure): rename uses of version to revision * chore(core): rename review changes action to history
…el (#7435) * feat(structure): add history and review tabs to changes inspector panel * fix(structure): move changes inspector navigation to paneRouter * fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot * fix(structure): rename uses of version to revision * chore(core): rename review changes action to history
…el (#7435) * feat(structure): add history and review tabs to changes inspector panel * fix(structure): move changes inspector navigation to paneRouter * fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot * fix(structure): rename uses of version to revision * chore(core): rename review changes action to history
…el (#7435) * feat(structure): add history and review tabs to changes inspector panel * fix(structure): move changes inspector navigation to paneRouter * fix(structure): update isReviewChangesOpen check in ChangeConnectorRoot * fix(structure): rename uses of version to revision * chore(core): rename review changes action to history
Description
This pull request joins the history revision and the review changes into 1 inspector, divided by tabs.
History tab
Reuses the existing
Timeline
component to render the view of theTimeline
and allows the user to select which revision to see in the form.By moving this into the history tab, the
TimelineMenu
was removed from theDocumentPanelHeader
Review changes tab
Reuses the existing Review changes, it now includes the From and To selector, making it easier for the user to understand where the changes he is seeing are coming from.
Other
When clicking the fields
ChangeBarButton
the inspector will open in the Review changes tab.When opening the inspector through the Actions menu, it will open in the History tab
What to review
Are the changes correct?
Is there something else to consider in this changes related to the review changes that may have been lost?
Testing
e2e testing to be included once designs are on a final stage and all the changes have been approved by design.
Notes for release
n/a this will go to a feature branch