Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(form): handle deeply nested paths in arrays #7042

Merged
merged 6 commits into from
Jun 28, 2024
Merged

fix(form): handle deeply nested paths in arrays #7042

merged 6 commits into from
Jun 28, 2024

Conversation

sjelfull
Copy link
Member

Description

Fixes copying and pasting deeply nested paths inside arrays.

@sjelfull sjelfull requested a review from hermanwikner June 28, 2024 13:05
@sjelfull sjelfull self-assigned this Jun 28, 2024
@sjelfull sjelfull requested a review from a team as a code owner June 28, 2024 13:05
@sjelfull sjelfull requested review from rexxars and removed request for a team June 28, 2024 13:05
@vercel Vercel
Copy link

vercel bot commented Jun 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 4:00pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 4:00pm
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 4:00pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 4:00pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 4:00pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jun 28, 2024 4:00pm

@sjelfull sjelfull force-pushed the fix/copy-paste-edx-1514 branch from 7aa32d9 to e6b4820 Compare June 28, 2024 13:53
@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024 •
edited
Loading

Component Testing Report Updated Jun 28, 2024 4:12 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 32s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 37s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ❌ Failed (Inspect) 46s 3 4 5
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 11s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 46s 2 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 50s 17 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 16s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 9s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 27s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 18s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 36s 12 0 0

@sjelfull sjelfull merged commit 583d337 into feat/global-copy-paste Jun 28, 2024
26 of 32 checks passed
@sjelfull sjelfull deleted the fix/copy-paste-edx-1514 branch June 28, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hermanwikner hermanwikner Awaiting requested review from hermanwikner

@rexxars rexxars Awaiting requested review from rexxars rexxars was automatically assigned from sanity-io/sdk

Assignees

@sjelfull sjelfull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sjelfull