Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(typegen): track empty union type nodes generated #6495

Merged
merged 1 commit into from
Apr 29, 2024
Merged

chore(typegen): track empty union type nodes generated #6495

merged 1 commit into from
Apr 29, 2024
+32 −9

Conversation

sgulseth
Copy link
Member

Description

This helps us determining if we might be reducing the scope wrong.

What to review

Testing

We don't have any tests for this atm.

Notes for release

n/a - no notes needed

@sgulseth sgulseth requested a review from a team April 26, 2024 12:40
@sgulseth sgulseth requested a review from a team as a code owner April 26, 2024 12:40
@vercel Vercel
Copy link

vercel bot commented Apr 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 27, 2024 1:43am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2024 1:43am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2024 1:43am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2024 1:43am

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 26, 2024 •
edited
Loading

Component Testing Report Updated Apr 27, 2024 1:47 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 13s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 36s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 5s 13 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 20s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 14s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 22s 9 0 0

@sgulseth sgulseth requested a review from a team April 26, 2024 23:33
@sgulseth sgulseth requested a review from a team as a code owner April 26, 2024 23:33
@sgulseth sgulseth requested review from skogsmaskin and juice49 and removed request for a team April 26, 2024 23:33
@rexxars rexxars force-pushed the chore/typegen/track-empty-unions-generated branch from ddbc9c9 to a764e63 Compare April 27, 2024 01:37
@sgulseth sgulseth removed the request for review from skogsmaskin April 29, 2024 09:50
@sgulseth sgulseth added this pull request to the merge queue Apr 29, 2024
Merged via the queue into next with commit 124be88 Apr 29, 2024
39 checks passed
@sgulseth sgulseth deleted the chore/typegen/track-empty-unions-generated branch April 29, 2024 15:31
cngonzalez pushed a commit that referenced this pull request May 8, 2024
@sgulseth @cngonzalez
chore(typegen): track empty union type nodes generated (#6495)
f70ca3e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svirs svirs svirs approved these changes

@juice49 juice49 juice49 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgulseth @juice49 @svirs