Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify 'shopify' template schema #6161

Merged
merged 30 commits into from
Apr 4, 2024
Merged

simplify 'shopify' template schema #6161

merged 30 commits into from
Apr 4, 2024

Conversation

SimeonGriggs
Copy link
Contributor

Description

Simplifies the shopify starter template schema

What to review

That init-ing a new Studio with the shopify template still compiles correctly.

Testing

None added, but tested locally.

Notes for release

Simplified shopify schema template

@vercel Vercel
Copy link

vercel bot commented Apr 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 4, 2024 8:47am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 8:47am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 8:47am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

Component Testing Report Updated Apr 4, 2024 8:51 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 34s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 2s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 2s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 20s 9 0 0

stipsan and others added 20 commits April 3, 2024 05:14
@stipsan
chore(renovate): pin framer-motion to known stable (#6166)
ca61b8f
@ecospark @github-merge-queue
chore(prettier): fix unformatted files 🤖 ✨ (#6168)
e7d77da 
Co-authored-by: github-merge-queue[bot] <118344674+github-merge-queue[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency @sanity/icons to ^2.11.6 (#6169)
17f8b6d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency turbo to ^1.13.2 (#6170)
6b3a73e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency vite to ^4.5.3 (#6171)
4d7896f 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(lockfile): update dependency @portabletext/react to v3.0.15 (#6172
e4f9174 
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(lockfile): update dependency @sanity/color to v3.0.4 (#6173)
964217f 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(lockfile): update dependency @sanity/logos to v2.1.8 (#6175)
8b68987 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): Update react monorepo (#6176)
dd51aaa 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency @sanity/client to ^6.15.9 (#6177)
a3a8b5b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update dependency use-hot-module-reload to v2 (#6180)
63aab83 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@stipsan
Revert "chore(deps): update dependency use-hot-module-reload to v2 (#…
eaa442c 
…6180)" (#6182)

This reverts commit 63aab83.
@renovate
fix(deps): update dependency @sanity/ui to ^2.0.13 (#6178)
e9e7864 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency get-it to ^8.4.17 (#6179)
b276e94 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@stipsan
fix(deps): pin framer-motion to the same version used by @sanity/ui (…
bbd3702 
…#6183)
@stipsan
chore: fix typings error
fee980f
@ecospark @stipsan
chore(deps): dedupe pnpm-lock.yaml (#6184)
cbfff74 
Co-authored-by: stipsan <[email protected]>
@renovate
chore(deps): lock file maintenance (#6186)
c246c29 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@stipsan
chore: pin @sanity/eslint-config-i18n
a986388
@stipsan
chore: pin @playwright/test
56c743e
@SimeonGriggs SimeonGriggs requested a review from nkgentile April 3, 2024 08:17
renovate bot and others added 3 commits April 3, 2024 08:19
@renovate
chore(deps): lock file maintenance (#6187)
d63429e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@stipsan @bjoerge
fix: use named styled import for better ESM runtime compat (#6185)
f40d172 
* fix: use named `styled` import for better ESM runtime compat

* chore(eslint): add eslint rule to enforce named styled import from styled-components (#6188)

---------

Co-authored-by: Bjørge Næss <[email protected]>
@thebiggianthead
update store ID format
2f57c07
thebiggianthead
thebiggianthead approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@thebiggianthead thebiggianthead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all looks good. Added updates to Shopify admin URL to support new domain shape, and navbar icon to jump to Shopify admin.

jtpetty
jtpetty approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimeonGriggs SimeonGriggs requested a review from a team April 3, 2024 17:51
@SimeonGriggs SimeonGriggs requested a review from a team as a code owner April 3, 2024 17:51
@SimeonGriggs SimeonGriggs requested review from ninaandal and rexxars and removed request for a team April 3, 2024 17:51
@SimeonGriggs SimeonGriggs added this pull request to the merge queue Apr 4, 2024
Merged via the queue into next with commit 69ff15f Apr 4, 2024
36 checks passed
@SimeonGriggs SimeonGriggs deleted the feat/shopify-template-simplify branch April 4, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpetty jtpetty jtpetty approved these changes

@thebiggianthead thebiggianthead thebiggianthead approved these changes

@nkgentile nkgentile Awaiting requested review from nkgentile

@ninaandal ninaandal Awaiting requested review from ninaandal

@rexxars rexxars Awaiting requested review from rexxars rexxars was automatically assigned from sanity-io/sdk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimeonGriggs @thebiggianthead @jtpetty @stipsan