Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schema): handle assetRequired when extracting schema with enforceRequiredFields #6157

Conversation

sgulseth
Copy link
Member

@sgulseth sgulseth commented Apr 2, 2024

Description

Follow up from #6151

If the schema is setting assetRequired() on an asset-field, we mark the underlying asset attribute as non-optional

What to review

Correct implementation? Tested it with a compiled schema as well, and works as expected.

Testing

Notes for release

n/a - no notes needed

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 2, 2024 9:06am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 9:06am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Apr 2, 2024 9:06am

Copy link
Member Author

sgulseth commented Apr 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sgulseth and the rest of your teammates on Graphite Graphite

@sgulseth sgulseth requested a review from rexxars April 2, 2024 09:02
@sgulseth sgulseth marked this pull request as ready for review April 2, 2024 09:02
@sgulseth sgulseth requested a review from a team as a code owner April 2, 2024 09:02
Copy link
Contributor

github-actions bot commented Apr 2, 2024

No changes to documentation

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Component Testing Report Updated Apr 2, 2024 9:09 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 33s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 24s 8 0 1

@sgulseth sgulseth added this pull request to the merge queue Apr 2, 2024
Merged via the queue into next with commit cd52979 Apr 2, 2024
36 checks passed
@sgulseth sgulseth deleted the 04-02-feat_schema_handle_assetrequired_when_extracting_schema_with_enforcerequiredfields branch April 2, 2024 11:58
kmelve pushed a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants