Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tasks): tasks UI updates. #6136

Merged
merged 17 commits into from
Apr 8, 2024
Merged

fix(tasks): tasks UI updates. #6136

merged 17 commits into from
Apr 8, 2024

Conversation

pedrobonamin
Copy link
Contributor

@pedrobonamin pedrobonamin commented Mar 27, 2024 •
edited
Loading

Description

Fixes:

  • force assignee selection menu to bottom position

  • reduce description input min height in edit mode

  • increase distance between actions in form create

  • update placeholder texts

  • edx-1202 Don't create empty tasks in the form.

  • edx-1207 User Icon and text misaligned in activity feed
    Screenshot 2024-03-27 at 11 39 23

  • edx-1208 Comment icon alignment off
    Screenshot 2024-03-27 at 15 14 13

  • edx-1209 Padding on comment reply too large and inconsistent with new comment creation spacing.
    Screenshot 2024-03-27 at 12 39 49

  • edx-1211 Don't line break dates in activity log
    Screenshot 2024-03-27 at 11 30 26

  • EDX-1219 Remove disabled from document tab
    Screenshot 2024-03-27 at 18 33 31

  • EDX-1220 UI Fix: Add tooltips to selection tokens for task status, assignee, and due date
    https://github.com/sanity-io/sanity/assets/46196328/ed72d806-53fc-4920-a57b-aefef2e1d2fc

What to review

Testing

Notes for release

@vercel Vercel
Copy link

vercel bot commented Mar 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Apr 5, 2024 9:39am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 9:39am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Apr 5, 2024 9:39am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024 •
edited
Loading

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024 •
edited
Loading

Component Testing Report Updated Apr 5, 2024 9:41 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 26s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 3s 14 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 1s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 19s 9 0 0

ninaandal
ninaandal approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@ninaandal ninaandal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@ninaandal ninaandal self-requested a review March 27, 2024 10:41
@pedrobonamin pedrobonamin marked this pull request as ready for review March 27, 2024 14:20
@pedrobonamin pedrobonamin requested a review from a team March 27, 2024 14:20
@pedrobonamin pedrobonamin changed the title fix(tasks): don't line break dates in activity log fix(tasks): tasks UI updates. Mar 27, 2024
@pedrobonamin pedrobonamin requested a review from ninaandal March 27, 2024 18:16
@pedrobonamin pedrobonamin requested a review from rexxars April 2, 2024 08:59
@pedrobonamin pedrobonamin enabled auto-merge April 5, 2024 10:23
rexxars
rexxars approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the clarifying comments on the i18n resources! LGTM

@pedrobonamin pedrobonamin added this pull request to the merge queue Apr 8, 2024
Merged via the queue into next with commit d45b210 Apr 8, 2024
36 checks passed
@pedrobonamin pedrobonamin deleted the fix-tasks-ui branch April 8, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ninaandal ninaandal ninaandal approved these changes

@rexxars rexxars rexxars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pedrobonamin @rexxars @ninaandal