Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks): add tasks empty states #6130

Merged
merged 1 commit into from
Mar 26, 2024
Merged

feat(tasks): add tasks empty states #6130

merged 1 commit into from
Mar 26, 2024

Conversation

pedrobonamin
Copy link
Contributor

Description

  • Adds empty states to tasks. To improve discoverability of tasks, empty states are modified, including more details and how's to.
  • Fixes an issue when removing tasks.
  • Fixes overflow issue in tasks document preview.

Examples

Screenshot 2024-03-26 at 12 29 49 Screenshot 2024-03-26 at 12 41 08

What to review

Testing

Notes for release

@pedrobonamin pedrobonamin requested review from a team and jtpetty and removed request for a team March 26, 2024 12:08
Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
performance-studio ✅ Ready (Inspect) Visit Preview Mar 26, 2024 2:47pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 2:47pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 2:47pm

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Mar 26, 2024

Component Testing Report Updated Mar 26, 2024 2:52 PM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 31s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 6s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 12s 3 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 12s 4 2 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 32s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 0s 15 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 3s 18 0 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 12s 6 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 13s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 21s 9 0 0

Copy link
Contributor

@jtpetty jtpetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@pedrobonamin pedrobonamin added this pull request to the merge queue Mar 26, 2024
Merged via the queue into next with commit 22afbb4 Mar 26, 2024
36 checks passed
@pedrobonamin pedrobonamin deleted the edx-1172 branch March 26, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants